New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report current version on addon updates #5324

Closed
nvaccessAuto opened this Issue Aug 29, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@nvaccessAuto

nvaccessAuto commented Aug 29, 2015

Reported by leonarddr on 2015-08-29 05:27
When you install an addon that is already installed, NVDA asks you to update. I think it can be a handy addition whenever NVDA reports the current version of the addon as well as the version being updated to. Furthermore, a downgrade warning could be considered in line with NVDAs update meganism.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 29, 2015

Comment 1 by beqa on 2015-08-29 13:23
hi.

do you mean this?
if gui.messageBox(_("A version of this add-on is already installed. Would you like to update it?\nCurrent version:{curversion}\nNew version:{newversion}").format(curversion=addon.manifest[newversion=bundle.manifest"version"),

nvaccessAuto commented Aug 29, 2015

Comment 1 by beqa on 2015-08-29 13:23
hi.

do you mean this?
if gui.messageBox(_("A version of this add-on is already installed. Would you like to update it?\nCurrent version:{curversion}\nNew version:{newversion}").format(curversion=addon.manifest[newversion=bundle.manifest"version"),

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 29, 2015

Comment 2 by leonarddr on 2015-08-29 13:32
Sounds great

nvaccessAuto commented Aug 29, 2015

Comment 2 by leonarddr on 2015-08-29 13:32
Sounds great

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 29, 2015

Comment 3 by beqa on 2015-08-29 13:39
ok, i will create that branch.

nvaccessAuto commented Aug 29, 2015

Comment 3 by beqa on 2015-08-29 13:39
ok, i will create that branch.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 29, 2015

Comment 4 by beqa on 2015-08-29 14:38
branch is at:
https://bitbucket.org/beqa/nvda

nvaccessAuto commented Aug 29, 2015

Comment 4 by beqa on 2015-08-29 14:38
branch is at:
https://bitbucket.org/beqa/nvda

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jul 8, 2017

Collaborator

I don't know whether the @BeQa is the same BeQa, but it would be great if you'd be able to create a pr for this.

Collaborator

leonardder commented Jul 8, 2017

I don't know whether the @BeQa is the same BeQa, but it would be great if you'd be able to create a pr for this.

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 2, 2017

feerrenrut added a commit that referenced this issue Oct 2, 2017

Enhance add-on installation messages to display version information (PR
#7542)

* addonManager: show current version and version beeing updated when updating an addon.

Fixes #5324

@josephsl josephsl referenced this issue Oct 15, 2017

Merged

Docs17.4 #7662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment