New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA does not recognise HTML 5 structural elements in IE #5591

Closed
andrew-l-d opened this Issue Dec 7, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@andrew-l-d

andrew-l-d commented Dec 7, 2015

NVDA does not recognise <header>, <nav>, <main> and <footer> in IE but does in Firefox and Chrome. If it could, performance would be very similar to other Windows screen readers and VoiceOver. This would allow developers to use these tags without the need for ARIA equivalents.

Andrew

@jcsteh jcsteh added the goodForNewDev label Dec 7, 2015

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Dec 7, 2015

Contributor

Implementation notes:

  1. Create a map of these HTML tag names to ARIA landmark roles. Put it in the aria module. I think there's spec/guidelines somewhere for this, but at the very least, you can just test with Firefox.
  2. The actual work should be done in virtualBuffers.MSHTML.MSHTMLTextInfo._normalizeControlField. There's already code there that deals with landmarks. If there aren't ARIA landmarks, use the map from 1) to derive one.
Contributor

jcsteh commented Dec 7, 2015

Implementation notes:

  1. Create a map of these HTML tag names to ARIA landmark roles. Put it in the aria module. I think there's spec/guidelines somewhere for this, but at the very least, you can just test with Firefox.
  2. The actual work should be done in virtualBuffers.MSHTML.MSHTMLTextInfo._normalizeControlField. There's already code there that deals with landmarks. If there aren't ARIA landmarks, use the map from 1) to derive one.

@jcsteh jcsteh changed the title from NVDA does not recognise regions in IE to NVDA does not recognise HTML 5 structural elements in IE Apr 27, 2016

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh
Contributor

jcsteh commented Apr 28, 2016

feerrenrut added a commit that referenced this issue Jun 7, 2016

Fix issue #5591
Issue: NVDA does not recognise HTML 5 structural elements in IE
See #5591

Added a mapping for HTML elemetns to ARIA landmark roles which
is now considered when looking for landmarks.
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Jun 7, 2016

Contributor

What I believe each of the missing elements should do, based on what Firefox or Chrome do, and cross referenced with w3.org ARIA information:

 <main> = "main landmark"
 <header> = "banner landmark"
 <nav> =  "navigation landmark"
 <footer> = "content info landmark"

A gist example file for testing

Pressing the d key to navigate through landmarks should also be handled.

Contributor

feerrenrut commented Jun 7, 2016

What I believe each of the missing elements should do, based on what Firefox or Chrome do, and cross referenced with w3.org ARIA information:

 <main> = "main landmark"
 <header> = "banner landmark"
 <nav> =  "navigation landmark"
 <footer> = "content info landmark"

A gist example file for testing

Pressing the d key to navigate through landmarks should also be handled.

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Jun 16, 2016

Contributor

Incubated in 24458af

Contributor

feerrenrut commented Jun 16, 2016

Incubated in 24458af

@feerrenrut feerrenrut self-assigned this Jul 6, 2016

@jcsteh jcsteh added this to the 2016.3 milestone Aug 5, 2016

@feerrenrut feerrenrut removed their assignment Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment