Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille/Liblouis 3: provide a way to detect and change table names if old tables are no longer included #6140

Closed
josephsl opened this issue Jul 5, 2016 · 0 comments
Milestone

Comments

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jul 5, 2016

Hi,
Part of #6109:

As noted in the following LibLouis issue:
liblouis/liblouis#182

There might be instances where NVDA's own tables tuple may refer to deleted tables. If this happens, the following may result:

  1. Braille Settings: no table seems to be selected. This is a minor thing (for about 99 percent of tables, table names are the same).
  2. Runtime translation issues are noted due to the fact that some tables rely on other tables.

Thus it would be handy to provide the following migration strategy:

  1. Add config checker in braille.initialize that reads in config.conf["braille"]["*Table"] key.
  2. Based on the name of the file it read, look up a dictionary which tells NVDA the new filename for the given table.
  3. Replace the old name with the new name.

Potential problems:

  • What if no replacements are provided? In this case, tell users to specify the new table from braille settings.
  • Do we know which tables are gone or renamed? We need to wait until LibLouis 3 beta comes out before proceeding.

The needed change(s) will be committed as part of #6109 branch (#6110 for PR). Comments are appreciated. Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Jul 6, 2016
…w filenames. re nvaccess#6140.

Given that people would be surprised if some tables would revert back to defaults, it would be handy to provide a short migration routine to map old table filenames to new ones. Thus, a tempoary routine and a map is introduced to handle it (to be removed at a future date).
josephsl added a commit to josephsl/nvda that referenced this issue Jul 15, 2016
More table renames for Danish (6-dot series) and Dutch, along with entries for them in migration map.
jcsteh added a commit that referenced this issue Sep 27, 2016
@jcsteh jcsteh closed this in #6110 Oct 11, 2016
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 11, 2016
jcsteh added a commit that referenced this issue Oct 11, 2016
…nt enhancements to Unified English Braille. (#6109, #4194, #6220, #6140)

As there were quite a few changes to table file names required for this version of liblouis, this also includes code to migrate old table file names to new ones.
PR #6110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants