Excel: Disable auto passThrough mode in Excel's browse mode by default #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, so that pressing escape before ever using browse mode does not drop into browse mode. Also ensure that NVDA disables / enables autoPassThroughMode on togglePassThroughMode for all browseMode treeInterceptors, not just browseModeDocumentTreeInterceptors.
|
@feerrenrut a review please. |
feerrenrut
approved these changes
Nov 17, 2016
|
There was no issue. On 11/17/2016 6:22 PM, Reef Turner wrote:
Michael Curran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excel has a browse mode treeInterceptor, which starts in focus mode, so that the user can bring up the NVDA elements list without having to switch to browse mode first. However, at current, if the user presses escape, they drop into browse mode, which can be confusing and unproductive, especially when escaping too many times out of editing a cell. This pr ensures that autoPassThrough is disabled by default, meaning that focus mode is locked unless the user manually switches to browse mode. Escape will still work if switching to focus mode when pressing enter on a form field. This brings the experience inline with all other browse mode implementations.