Allow enabling/disabling error sounds in release versions

[LeonarddeR]

NVDA error sounds are only played in development builds. However, there are situations where playing these sounds in release versions would be very helpful.

I've been thinking about adding an option for this to the config spec, but that would override the current behaviour entirely, i.e. when you install a release version and install a dev version afterwards, the error sound wouldn't play. As an alternative, I propose adding a registry setting for this which will be preserved upon new installations.

[jcsteh]

You assert that there are cases where this would be useful, but you don't state what those cases are. Can you elaborate? Essentially, the error sound is there purely to help developers debug issues. Often, such errors don't necessarily even indicate a cause for concern. Furthermore, if someone really does care about such things, requiring them to install a snapshot doesn't seem unreasonable. Other projects have similar requirements; e.g. stable Mozilla builds won't run unsigned add-ons.

[jcsteh]

Btw, you can already enable this by setting versionInfo.isTestVersion to True in the Python console. If someone cares about these errors, expecting them to use the console isn't unreasonable either. All of that said, if we really did need a setting for this, it could just be a setting that is only checked for test builds.

[jcsteh]

Correction: only checked for stable builds.

[Brian1Gaff]

I don't think this is needed. It will confuse people if its set on for some odd reason, say a person other than the user wanted to update to a release version from a dev one or vice versa. It is very confusing I have often asked on the dev list if a given error is an issue and been told its not if it recovers and does not screw anything up. After all, one can always put in a snapshot at the moment to see if there is an error if things look like they are affecting the workings of nvda, but hopefully stable versions should not really involve a user in worrying about beeps that have been accidentally turned on. The branch of RC release candidates, ie not the final release candidate but the last one on the snaps page still has errors enabled and is functionally the same as the release if anyone needs to check out this problem. Just my few penneth. Besides with the portable version you would not want to start fiddling with the registry. Brian bglists@blueyonder.co.uk Sent via blueyonder. Please address personal email to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "Leonard de Ruijter" <notifications@github.com> To: "nvaccess/nvda" <nvda@noreply.github.com> Cc: "Subscribed" <subscribed@noreply.github.com> Sent: Friday, February 24, 2017 5:55 PM Subject: [nvaccess/nvda] Allow enabling/disabling error sounds in release versions (#6917)

…

NVDA error sounds are only played in development builds. However, there are situations where playing these sounds in release versions would be very helpful. I've been thinking about adding an option for this to the config spec, but that would override the current behaviour entirely, i.e. when you install a release version and install a dev version afterwards, the error sound wouldn't play. As an alternative, I propose adding a registry setting for this which will be preserved upon new installations. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #6917

[derekriemer]

For addon dev it's really nice to know if there's a bug. I have a toggle test version addon (It was written in 5 minutes, and has not been reviewed and won't be reviewed because I can't be bothered). https://files.derekriemer.com/disable_debug_sound.7z

…

On Sat, Feb 25, 2017 at 3:25 AM, Brian1Gaff ***@***.***> wrote: I don't think this is needed. It will confuse people if its set on for some odd reason, say a person other than the user wanted to update to a release version from a dev one or vice versa. It is very confusing I have often asked on the dev list if a given error is an issue and been told its not if it recovers and does not screw anything up. After all, one can always put in a snapshot at the moment to see if there is an error if things look like they are affecting the workings of nvda, but hopefully stable versions should not really involve a user in worrying about beeps that have been accidentally turned on. The branch of RC release candidates, ie not the final release candidate but the last one on the snaps page still has errors enabled and is functionally the same as the release if anyone needs to check out this problem. Just my few penneth. Besides with the portable version you would not want to start fiddling with the registry. Brian ***@***.*** Sent via blueyonder. Please address personal email to:- ***@***.***, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "Leonard de Ruijter" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Subscribed" ***@***.***> Sent: Friday, February 24, 2017 5:55 PM Subject: [nvaccess/nvda] Allow enabling/disabling error sounds in release versions (#6917) > NVDA error sounds are only played in development builds. However, there > are situations where playing these sounds in release versions would be > very helpful. > > I've been thinking about adding an option for this to the config spec, but > that would override the current behaviour entirely, i.e. when you install > a release version and install a dev version afterwards, the error sound > wouldn't play. As an alternative, I propose adding a registry setting for > this which will be preserved upon new installations. > > -- > You are receiving this because you are subscribed to this thread. > Reply to this email directly or view it on GitHub: > #6917 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6917 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFGivRbqNl-l5-Wr8-r4CxRXL48ECQcbks5rgAGogaJpZM4MLfto> .

-- Derek Riemer: Improving the world one byte at a time! - University of Colorado Boulder Department of computer science, 4th year undergraduate student. - Accessibility enthusiast. - Proud user of the NVDA screen reader. - Open source enthusiast. - Skier. Personal website <http://derekriemer.com>

[LeonarddeR]

Ah, I overlooked the versionInfo.isTestVersion parameter. Setting that one to True solves the issue for me, so closing.
@derekriemer: Thanks for the add-on