Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next snapshot ignoring browse mode settings in search edit fields like google or startpage #7323

Closed
Brian1Gaff opened this issue Jun 25, 2017 · 3 comments
Assignees

Comments

@Brian1Gaff
Copy link

Brian1Gaff commented Jun 25, 2017

Using latest next downloaded on 24th June 17, when options in brows mode set to allow cursoring through edit fields so you can hear focus and browse mode changes, this particular snap when usedwith firefox 54 and earlier only lets you out of edit with cursor left. all other directions result in no movement, though you can tab out.
Normal web site form fields seem to be unaffected.
This was tested on windows 7 64 with 32 bit Firefox and also Windows xp, both portable and installed.
Earlier snaps in Next are not affected. Master is not affected.
Automatic focus mode for focus changes
Automatic focus mode for caret movement
both checked

@jcsteh
Copy link
Contributor

jcsteh commented Jun 25, 2017

Regression caused by c967b21 (#7201). It seems Firefox incorrectly fires caret events when you press most cursor keys even if you're already at the edge of the control.

@jcsteh jcsteh self-assigned this Jun 25, 2017
jcsteh added a commit that referenced this issue Jun 26, 2017
…sed by c967b21.

Firefox fires caret events even when you use caret movement commands when already at the edge of the control. That means we don't fire caretMovementFailed events in these cases. Furthermore, it seems quite a few things (e.g. Wordpad, Notepad++) don't fire valueChange or caret events when you press delete.
To work around this, drop the checks for caret and valueChange events (and revert the shouldAllowSystemCaretEvent stuff). Instead, when pressing delete, compare the word at the caret (in addition to bookmarks) to detect movement.
jcsteh added a commit that referenced this issue Jun 26, 2017
@jcsteh jcsteh closed this as completed Jun 26, 2017
@jcsteh
Copy link
Contributor

jcsteh commented Jun 26, 2017

Fixed in 4a908f3; merged into next in 1102092.

@Brian1Gaff
Copy link
Author

Brian1Gaff commented Jun 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants