-
-
Notifications
You must be signed in to change notification settings - Fork 626
-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVDA voices "button" for checkboxes for the app Backup and Sync #7613
Comments
Confirmed, but I don't know if they are checkboxes or real buttons. On the
last case, NVDA should announce "pressed" or "not pressed".
Regards,
Rui
…-----Mensagem Original-----
De: rishsharma
Data: 19 de setembro de 2017 23:24
Para: nvaccess/nvda
Cc: Subscribed
Assunto: [nvaccess/nvda] NVDA voices "button" for checkboxes for the app
Backup and Sync (#7613)
Steps to reproduce:
Open a new install of Backup and Sync from
https://www.google.com/drive/download/
Access any checkboxes. NVDA indicates they are buttons.
Expected behavior:
Checkboxes should be announced as checkboxes.
Actual behavior:
Checkboxes are announced as buttons
System configuration:
NVDA version:
2017.3
NVDA Installed or portable:
Other information:
Running in a VM
Windows version:
Windows 7 64 bit
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
No
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Could you please update the steps to reproduce to explain where in the app you find this behaviour? I am not able to reproduce it. |
This is not an NVDA issue, but an issue needs filed with Google to fix this (And they really ot to add tests for this kind of breakage) unless they just intended to have check buttons here, not checkboxes. |
Hi, I'm a dev from Google that works on the product Backup and Sync and the original person who filed the bug. The application Backup and Sync uses wxPython's wx.Checkbox class. It is possible that this is not implemented by wxWidgets using the canonical Checkbox control in Windows although I find it somewhat unlikely. I noticed NVDA also uses wxPython. Backup and Sync uses wxPython 3.0.2.0. Are there any known bugs with that library with NVDA? Is there something I may be missing? AFAICT the application is using the correct control and thats why I filed this bug in the first place. Apologies if I'm wrong. Thanks, -R |
I was able to trace the problem in our code to setting a foreground color on a wx.Checkbox causes NVDA to change it detecting as a checkbox to a button. The exact code was: control.SetForegroundColour(wx.Colour(33, 33, 33, 255)) |
Thanks @derekriemer for the steps to reproduce, I can reproduce this now. @rishsharma thanks for the extra information. I think we should investigate if we can improve the way that we handle this in NVDA if we can. I'll leave this issue open and give it a priority 3, while it's not ideal and a bit confusing the impact to a user is fairly low. |
I believe this issue is now fixed in Backup and Sync. I went into the settings and preferences of the program, and checkboxes were correctly announced. CC @derekriemer and @rishsharma to see if it is fixed for them as well. |
I believe we "fixed" it in Backup and Sync by not using SetForegroundColour. Otherwise I think this is still an issue. |
should be kept open until we can figure out how foreground color is changing the role. |
Is this related to displaymodel? cc: @LeonarddeR |
Backup and sync has been discontinued in 2021 and replaced by Google Drive for Desktop. If you have the same issue with Google Drive for Deskto, please open a new issue. I am closing as abandoned. |
Steps to reproduce:
Expected behavior:
Checkboxes should be announced as checkboxes.
Actual behavior:
Checkboxes are announced as buttons
System configuration:
NVDA version:
2017.3
NVDA Installed or portable:
Other information:
Running in a VM
Windows version:
Windows 7 64 bit
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
No
The text was updated successfully, but these errors were encountered: