Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA voices "button" for checkboxes for the app Backup and Sync #7613

Closed
rishsharma opened this issue Sep 19, 2017 · 11 comments
Closed

NVDA voices "button" for checkboxes for the app Backup and Sync #7613

rishsharma opened this issue Sep 19, 2017 · 11 comments
Labels
Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. bug p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority wxPython3

Comments

@rishsharma
Copy link

Steps to reproduce:

  1. Open a new install of Backup and Sync from https://www.google.com/drive/download/
  2. Access any checkboxes. NVDA indicates they are buttons.

Expected behavior:

Checkboxes should be announced as checkboxes.

Actual behavior:

Checkboxes are announced as buttons

System configuration:

NVDA version:
2017.3

NVDA Installed or portable:

Other information:
Running in a VM

Windows version:
Windows 7 64 bit

Does the issue still occur after restarting your PC?
Yes

Have you tried any other versions of NVDA?
No

@ruifontes
Copy link
Contributor

ruifontes commented Sep 20, 2017 via email

@feerrenrut
Copy link
Contributor

Could you please update the steps to reproduce to explain where in the app you find this behaviour? I am not able to reproduce it.
Is it in the installer for "Backup and Sync", or somewhere in the settings after install?

@derekriemer
Copy link
Collaborator

  1. windows+b.
  2. press b until backup and sync is present. Press enter.
  3. Now, press the settings button, then choose preferences.
  4. tab through your settings until you reach the what were once checkboxes for selecting a folder to backup on your computer.

This is not an NVDA issue, but an issue needs filed with Google to fix this (And they really ot to add tests for this kind of breakage) unless they just intended to have check buttons here, not checkboxes.

@rishsharma
Copy link
Author

rishsharma commented Sep 20, 2017

Hi, I'm a dev from Google that works on the product Backup and Sync and the original person who filed the bug.

The application Backup and Sync uses wxPython's wx.Checkbox class. It is possible that this is not implemented by wxWidgets using the canonical Checkbox control in Windows although I find it somewhat unlikely. I noticed NVDA also uses wxPython. Backup and Sync uses wxPython 3.0.2.0. Are there any known bugs with that library with NVDA? Is there something I may be missing? AFAICT the application is using the correct control and thats why I filed this bug in the first place. Apologies if I'm wrong.

Thanks,

-R

@rishsharma
Copy link
Author

I was able to trace the problem in our code to setting a foreground color on a wx.Checkbox causes NVDA to change it detecting as a checkbox to a button.

The exact code was:

control.SetForegroundColour(wx.Colour(33, 33, 33, 255))

@feerrenrut
Copy link
Contributor

Thanks @derekriemer for the steps to reproduce, I can reproduce this now.

@rishsharma thanks for the extra information. I think we should investigate if we can improve the way that we handle this in NVDA if we can.

I'll leave this issue open and give it a priority 3, while it's not ideal and a bit confusing the impact to a user is fairly low.

@feerrenrut feerrenrut added bug p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority wxPython3 labels Oct 2, 2017
@ehollig
Copy link
Collaborator

ehollig commented Oct 14, 2018

I believe this issue is now fixed in Backup and Sync. I went into the settings and preferences of the program, and checkboxes were correctly announced. CC @derekriemer and @rishsharma to see if it is fixed for them as well.

@rishsharma
Copy link
Author

I believe we "fixed" it in Backup and Sync by not using SetForegroundColour. Otherwise I think this is still an issue.

@derekriemer
Copy link
Collaborator

should be kept open until we can figure out how foreground color is changing the role.

@Adriani90
Copy link
Collaborator

Is this related to displaymodel?

cc: @LeonarddeR

nstockton added a commit to nstockton/Travel-Directions that referenced this issue Apr 3, 2021
@Adriani90 Adriani90 added the Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. label Sep 12, 2023
@Adriani90
Copy link
Collaborator

Backup and sync has been discontinued in 2021 and replaced by Google Drive for Desktop. If you have the same issue with Google Drive for Deskto, please open a new issue. I am closing as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. bug p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority wxPython3
Projects
None yet
Development

No branches or pull requests

6 participants