Support model specific gestures for braille displays when working with modifiers #7783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, however related to #6213 and #7517
Summary of the issue:
#6213 added support for braille display key modifiers, #7517 added model specific gestures. However, these systems did not respect each other, meaning that it was not possible to combine modifiers and model specific gestures
Description of how this pull request fixes the issue, based on Testing performed:
When one display key is assigned to alt and the other key is assigned to downArrow, combining both keys will result in the execution of alt+downArrow, also when neither, either or both of the two are model specific.
This also fixes a trivial bug in the handyTech driver where a model name for an input gesture contained a space, which does not follow the specs in braille.BrailleDisplayGesture.
Known issues with pull request:
None
Change log entry: