-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes to the ALVA driver #8230
Conversation
@DrSooom: just before I ask for review by @michaelDCurran, could you please check whether this try build works as advertised in the pr description? Note that this does not contain fixes for #8149. |
File: brailleDisplayDrivers/alva.py
This maybe could fail. Please change it to the following:
|
|
|
@DrSooom commented on 3 May 2018, 18:48 CEST:
This is really a bit out of scope for this issue. Note that you should actually only create bindings for model specific gestures if you have multiple models and you really believe that assignments between models should differ. For example, Handy Tech and Hims devices have some key assignments that differ across models by default. The general advise is to assign gestures to non model specific identifiers, i.e. the ones that start with alva: not the ones starting with alva:bc680. |
@LeonarddeR: As long as bug #8108 isn't solved it isn't possible to see in the Input Gestures window if a command is allocated with the obsolete br(alvabc6)- or with the new br(alva)-keys. So at the moment the only solution is to set up device specific hotkeys to see a different in the Input Gestures window. And no, deleting the complete "gestures.ini" is no solution. ;)
|
@DrSooom commented on 4 mei 2018 15:44 CEST:
I'm afraid that at some point, there isn't much else for you to do other than that, since a gestures.ini can get quite dirty when you add and remove gestures for different driver many times.
This is intentional. "None" just translates to None in inputCore.py at line 282. Looking at the code again, I see why assigning all these combinations to None doesn't make sense, because NVDA doesn't differenciate between forcefully disabled gestures and gestures that are just not in use. I guess in this case, it is the safest to take away the sp2+sp3 assignment to leftWindows. When we do that, sp2+sp3 translates to alt+escape, and sp2+sp3+whatever else won't be in use. Note that there are more drivers suffering from the issue that some keys are processed by NVDA while activating internal device functionality. @dkager: What do you think about removing the sp2+sp3 to left windows assignment altogether? |
@LeonarddeR: You can also change the alva.py as follows:
Edit: And change the following line as follows:
|
source/brailleDisplayDrivers/alva.py
Outdated
if isNoBC640: | ||
doubledKeyCount = DOUBLED_KEY_COUNTS.get(group) | ||
if doubledKeyCount: | ||
keyName = ("r" if number>=doubledKeyCount else "l") + keyName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add spaces around >=
.
source/brailleDisplayDrivers/alva.py
Outdated
@@ -429,27 +451,39 @@ class InputGesture(braille.BrailleDisplayGesture, brailleInput.BrailleInputGestu | |||
|
|||
def __init__(self, model, keys, brailleInput=False): | |||
super(InputGesture, self).__init__() | |||
isNoBC640 = model != ALVA_MODEL_IDS[0x40] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use a constant in place of 0x40?
Link to issue number:
Fixes #8106
Fixes #8074
Fixes #8360
Summary of the issue:
Description of how this pull request fixes the issue:
This will also provide a fix for Alva satellite used via protocol converter and Optelec BC6 driver does not detect some keys and some keys were assigned twice #8074
Testing performed:
Several tests by @DrSooom as noted in #8106
Known issues with pull request:
None
Change log entry:
Changes
Bug fixes