-
-
Notifications
You must be signed in to change notification settings - Fork 626
-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Google Sheets, when Braille support is enabled, individual cells are identified as "selected" #8766
Comments
This happens in all Aria role="gridcell": |
I guess we can easily apply the same logic to table cells as applied to list items, for which only the not selected state is announced. Is there any indication with speech that you've started a selection when you select multiple cells in Google Sheets? |
It did correctly report when multiple cells were selected, yes. E.g. "Cells C12 to E12 selected" and if I shift+right arrow again "Cells C12 to F12 selected". |
I created a try build |
That works fine for me - "selected" is only announced now when I select multiple cells. I have also let the original person know who reported this and requested they test your try build. I'll update if I hear back from them elsewhere. |
This works great. The only time when "selected" is announced is when a new header row is navigated to. For example: Also, the column header row is not announced in Google Sheets, but the row headers are. |
I'm afraid this no longer works, at least with Firefox Nightly 75 and Google Sheets. I've ensured that braille mode is enabled, but "selected" is announced for every cell for me. I've also tried with 2018.4 and it no longer works there, so I assume something has changed either in Firefox or in Google Sheets. @Qchristensen Can you confirm, and if you can reproduce reopen this one? |
This still works in Chrome Version 80.0.3987.122 (Official Build) (64-bit) I grabbed the following log snippet from when I pressed an arrow key: IO - inputCore.InputManager.executeGesture (10:38:49.568) - winInputHook (14284): |
Given that it seems to be unique to Firefox cc @jcsteh and @MarcoZehe |
As of https://bugzilla.mozilla.org/show_bug.cgi?id=1521438 (Firefox 66), Firefox now complies with the MSAA spec such that accSelection returns VT_EMPTY for no selected items, VT_DISPATCH for a single selected item and VT_UNKNOWN + IEnumVARIANT for multiple selected items. The code in #8879 doesn't handle the VT_DISPATCH case. |
This is now so far working well in Firefox. The only part I still encounter is in case of merged cells. Here NVDA still reports "selected". This should not be the case when the merged cells are not selected. cc: @michaelDCurran is this something which could be implemented as a followup of #8879? |
Steps to reproduce:
Open a spreadsheet on http://sheets.google.com/ (blank is fine)
Ensure accessibility and Braille support are enabled.
Navigate around the sheet with the arrow keys.
Actual behavior:
NVDA reads "Contents, selected, cell address" for each cell (where contents is the text in the cell and cell address is A2 or C12 or whatever the address is).
Expected behavior:
NVDA should only report "selected" when multiple cells are selected.
System configuration:
Firefox 62.0 64-bit or Chrome Version 69.0.3497.100 (Official Build) (64-bit)
(Behaviour the same on both).
NVDA Installed/portable/running from source:
NVDA 2018.3 installed.
Windows version:
Windows 10 fast Insidier build 17763.1
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
NVDA 2018.2.1 (portable)
NVDA alpha-16065,4eb7aa5b (portable)
The text was updated successfully, but these errors were encountered: