Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA does not read in the Fast Log Entry #8996

Closed
HegrJan opened this issue Nov 30, 2018 · 8 comments · Fixed by #11488
Closed

NVDA does not read in the Fast Log Entry #8996

HegrJan opened this issue Nov 30, 2018 · 8 comments · Fixed by #11488
Milestone

Comments

@HegrJan
Copy link

HegrJan commented Nov 30, 2018

Steps to reproduce:

-1. Download Fast Log Entry installer from http://df3cb.com/fle/
0. Install FLE

  1. Open FLE
  2. Try to navigate using cursor keys

Actual behavior:

The text (log content) is not read. There are unknown symbols on the braille display eg. '\x2023''\x6548''\x6461''\x7265'...

Expected behavior:

An edit field similar to Notepad filled with example log should be readable.

System configuration:

NVDA Installed/portable/running from source:

Installed

NVDA version:

2018.3.2

Windows version:

Windows 7 64bit Version 6.1.7601 Service Pack 1 Build 7601

Name and version of other software in use when reproducing the issue:

Fast Log Entry 2.12

Other information about your system:

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

  • NVDA 2017.3, Windows XP 32bit - works
  • NVDA 2018.3.2, Windows 10 32bit - doesn't work
  • NVDA 2018.3.2, Windows 10 64bit - doesn't work

Remarks

  • Commercial screenreaders work properly.
@HegrJan
Copy link
Author

HegrJan commented Apr 14, 2019

Problem still persists in NVDA 2019.1

@HegrJan
Copy link
Author

HegrJan commented Feb 12, 2020

Problem still persists in NVDA 2019.3.1

@Adriani90
Copy link
Collaborator

This seems to be a regression.
cc: @jcsteh, @michaelDCurran this regression is quite a long time ago, but maybe someone of you can find the coresponding cause for this.

@Adriani90
Copy link
Collaborator

@HegrJan I assume this is still reproducible. Is this correct?

@HegrJan
Copy link
Author

HegrJan commented May 11, 2020 via email

@HegrJan
Copy link
Author

HegrJan commented May 15, 2020

Problem still persists in NVDA 2020.1

@lukaszgo1
Copy link
Contributor

@HegrJan Just to make sure this is fixed for you coulld you please test with this try build?

@HegrJan
Copy link
Author

HegrJan commented Aug 12, 2020 via email

feerrenrut pushed a commit that referenced this issue Sep 9, 2020
Fixes #8996

In #8165 we started using Unidentifiededit for editable text fields in which there is a caret and which seems to support Edit API. While both of these criterion's are true for Fast Log Entry edit fields their WindowText contains complete garbage and UnidentifiedEdit relies on Windowtext being correct.

Instead:
1. For edit field in Fast Log Entry DisplayModelEditableText is used similar to the pre #8165 
2. DisplayModelEditableText no longer inherits from EditableText rather from EditableTextWithoutAutoSelectDetection which makes selection announced when the color used for highlight in a particular app is the default Windows highlight color  - This has been suggested by @jcsteh in #4535
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Sep 9, 2020
dawidpieper pushed a commit to dawidpieper/nvda that referenced this issue Sep 13, 2020
…s#11488)

Fixes nvaccess#8996

In nvaccess#8165 we started using Unidentifiededit for editable text fields in which there is a caret and which seems to support Edit API. While both of these criterion's are true for Fast Log Entry edit fields their WindowText contains complete garbage and UnidentifiedEdit relies on Windowtext being correct.

Instead:
1. For edit field in Fast Log Entry DisplayModelEditableText is used similar to the pre nvaccess#8165 
2. DisplayModelEditableText no longer inherits from EditableText rather from EditableTextWithoutAutoSelectDetection which makes selection announced when the color used for highlight in a particular app is the default Windows highlight color  - This has been suggested by @jcsteh in nvaccess#4535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants