Emoji panel: emoji search results, automation ID based event handler, catch attribute error exception when closing the panel #9112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipboard paste functionality.
…ich input panel technology should be handled. Re nvaccess#9104. Previously NVDA assumed that emoji panel is the only thing to be handled, thus looked up build number and child count. However, it was later discovered that different input panel features expose different automation ID's for various features. Thus use this (along with build number if appropriate) when dealing with different aspects of modern input panel.
…rents and objects, especially when closing emoji panel. Re nvaccess#9106.
In Windows 10 Version 1809 and later, people emoji includes skin tone modifiers. Thus detect this and move to the appropriate emoji when searching for people emoji.
…ne. Re nvaccess#9105. While searching for emojis in Version 1809 and later, name change event is fired by search block text. However, item selection event is also fired, which means only the results count will be announced, not the moji itself. Thus return from name change event if emoji search is under way.
|
Hi, Besides Mick, if possible, I'd like to ask @feerrenrut for a visual review - that is, to see if NVDA announces things as you use the emoji panel (Windows+period) in October 2018 Update and later, specifically if clipboard status is announced and emoji search result is actually announced. Thanks. |
|
Hi, Update: given 19h1_release branch from Microsoft has been activated (as of build 18323), this will mean a companion pull request will be created this weekend that brings UIA window open event support to File Explorer app module. Thanks. |
This was referenced Jan 27, 2019
|
I take it that this pr is still needed as well though?
|
|
Hi, yes please, as it takes care of changes to emoji panel introduced in 1809 and 19H1. Thanks.
From: Michael Curran <notifications@github.com>
Sent: Sunday, January 27, 2019 3:03 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Emoji panel: emoji search results, automation ID based event handler, catch attribute error exception when closing the panel (#9112)
I take it that this pr is still needed as well though?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#9112 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkMxMjk6rwB-1SOvXCtHqGOR_Jnzdks5vHjBBgaJpZM4Zkzww> . <https://github.com/notifications/beacon/AHgLkJ-XtU-2fGVIGcuWHjqc9dD4BOklks5vHjBBgaJpZM4Zkzww.gif>
|
michaelDCurran
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The foundation pull request to support Windows 10 Version 19H1 (tentatively 1903) emoji panel (the expanded input panel) and making the Composable Shell app module cleaner.
Link to issue number:
Fixes #9103
Fixes #9104
Fixes #9105
Fixes #9106
Summary of the issue:
Redesigned the Composable Shell app module/various event handlers, resolves some outstanding issues with Version 1809 and 19H1 emoji panel changes.
Description of how this pull request fixes the issue:
Resolves the following:
Testing performed:
Tested with various modern input features in build 17763 and later (including build 18305).
Known issues with pull request:
Currently first selected emoji nor clipboard status won't be announced in 19H1 (build 18305) because File Explorer (not Composable Shell) is responsible for handling UIA window open event, whereas this PR works in Version 1809 (build 17763) since the latter is the one handling window open event. This limitation is subject to change.
Change log entry:
Bug fixes:
Thanks.