Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retrieve formatting for the text under the cared #9505

Closed
lukaszgo1 opened this issue Apr 20, 2019 · 2 comments · Fixed by #10973
Closed

Add ability to retrieve formatting for the text under the cared #9505

lukaszgo1 opened this issue Apr 20, 2019 · 2 comments · Fixed by #10973
Milestone

Comments

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Apr 20, 2019

Is your feature request related to a problem? Please describe.

I am working all the time with review cursor and object navigation not following the cared mainly to be able to for instance read some instructions with the review cursor in the one window and work at the same time in the other program like sighted people are working by placing two windows side by side. Therefore each actions which require me to move review cursor from its current position slows me down considerably. One thing which I need to check relatively often is formatting of the text either when working in MS Word, or when composing some CSS. Currently to do this I have to either move my review cursor to my working window and lost my place of reading, or have braille display connected and use command to check formatting for the specific braille cell.
I propose adding script to check formatting under the cared not only for workflows like mine, but also not to make non braille users disadvantaged.

Describe the solution you'd like

As by default position of the review cursor and the cared is the same for most users pressing NVDA+F would report formatting of the character under the cared. In my opinion it makes sense to make NVDA+F report formatting under the cared and assign script for reporting formatting under the review cursor to the NVDA+Shift+F.

Describe alternatives you've considered

We can leave current assignment as is and create new script for reporting formatting under the cared unassigned.

Additional context

In most screen readers retrieving formatting under the cared is possible, and ad least for me it would be very beneficial.
I can work on this it don't seems to be hard in terms of coding, however it would be nice to have confirmation from @michaelDCurran or @feerrenrut that the feature would be approved and which of the two above solutions would you prefer.

@leonardder
Copy link
Collaborator

leonardder commented Apr 20, 2019

I recall there either is an issue for this already, or this has been discussed on a mailing list. Anyhow, this is a valid request and is not very difficult to implement, as long as the implementation ensures that the script only works when there is a caret.

@DrSooom
Copy link

DrSooom commented Apr 20, 2019

See issue #7869 and #8674 and PR #7990. A checkbox in the Document Formatting Settings would be fine as (later on) it should be possible to configure which formatting values should be spoken (and shown via Braille flash message) via NVDA+F and shown after Double-NVDA+F in a separate window.

michaelDCurran added a commit that referenced this issue Jun 23, 2020
* Add a command to check formatting for the text under the caret. Fix for #9505

* Move  commends for translators to make tests pass

* Linter fixes

* fix small typos in comments.

Co-authored-by: Michael Curran <mick@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants