Automatically set system focus to focusable elements: properly set focus when automatic focus mode is triggered

[LeonarddeR]

Many thanks to @lukaszgo1 for assisting in tracking this down!

This is opened against beta, since it fixes a regression introduced during 2020.3 development cycle

Link to issue number:

Fixes #11663
Replaces #11665

Summary of the issue:

With focus focusable elements disabled and Automatic focus mode for caret movements enabled when switching to focus mode as a result of caret movement focus was not moved to the control with caret. This made it impossible to, for example type text to the edit fields or properly interact with combo boxes.

Description of how this pull request fixes the issue:

Automatic focus mode is triggered when calling _set_selection on the browse mode document tree interceptor. The logic in this method has been changed to set focus to the object, either when Automatically set system focus to focusable elements is on or when we are going to pass through.

Testing performed:

Tested the steps to reproduce from #11663.

Known issues with pull request:

None

Change log entry:

Note, though this fixes a regression in 2020.3 beta, the auto set focus to focusable elements option was there before 2020.3.

• Bug fixes
  • When automatically set focus to focusable elements is disabled, NVDA once again sets focus to the focused object when focus mode is activated due to a focus change or caret movement. (System focus does not move to edit field when "Automatic focus mode for caret movement" is enabled. #11663)

[michaelDCurran]

I'm not sure the changelog entry is quite right though...
"When automatically set focus to focusable elements is enabled..." shouldn't it be disabled? or do you mean the automatic focus mode for caret movement?

[LeonarddeR]

A, I'm sorry. it should be disabled, indeed.

[LeonarddeR]

I fixed the changelog entry.

[feerrenrut]

This probably doesn't need a changelog entry if merged into beta, right?

[feerrenrut]

Thanks @LeonarddeR

[LeonarddeR]

Yes, it needs a changelog entry, as the feature, though experimental, has been there for several releases now.

[feerrenrut]

But entry is for a bug fix that was never in a release. We typically don't include a note for these. The feature presumably had / has its own change log entry.

[feerrenrut]

Though perhaps this could be worded such to mention that these two features are now compatible.

[feerrenrut]

EG:

• New Features
  • The settings "Automatic focus mode for caret movement" enabled and "automatically set focus to focusable elements" disabled (the new default) are now compatible. (System focus does not move to edit field when "Automatic focus mode for caret movement" is enabled. #11663)