-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically set system focus to focusable elements: properly set focus when automatic focus mode is triggered #11668
Conversation
…cus when automatic focus mode is triggered
I'm not sure the changelog entry is quite right though... |
A, I'm sorry. it should be disabled, indeed.
|
I fixed the changelog entry. |
This probably doesn't need a changelog entry if merged into beta, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LeonarddeR
Yes, it needs a changelog entry, as the feature, though experimental, has been there for several releases now. |
But entry is for a bug fix that was never in a release. We typically don't include a note for these. The feature presumably had / has its own change log entry. |
Though perhaps this could be worded such to mention that these two features are now compatible. |
EG:
|
c561d35
Many thanks to @lukaszgo1 for assisting in tracking this down!
This is opened against beta, since it fixes a regression introduced during 2020.3 development cycle
Link to issue number:
Fixes #11663
Replaces #11665
Summary of the issue:
With focus focusable elements disabled and Automatic focus mode for caret movements enabled when switching to focus mode as a result of caret movement focus was not moved to the control with caret. This made it impossible to, for example type text to the edit fields or properly interact with combo boxes.
Description of how this pull request fixes the issue:
Automatic focus mode is triggered when calling _set_selection on the browse mode document tree interceptor. The logic in this method has been changed to set focus to the object, either when Automatically set system focus to focusable elements is on or when we are going to pass through.
Testing performed:
Tested the steps to reproduce from #11663.
Known issues with pull request:
None
Change log entry:
Note, though this fixes a regression in 2020.3 beta, the auto set focus to focusable elements option was there before 2020.3.