Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 11966 to fix errors when interacting with edit fields in MS Excel #12429

Merged
merged 1 commit into from May 19, 2021

Conversation

lukaszgo1
Copy link
Contributor

This is opened against beta.

Link to issue number:

Work around for issue #12402

Summary of the issue:

PR #11966 started using DisplayModelEditableText for edit fields with empty window text to improve access to IDE's by MCS Electronic - this unfortunately broke access to some edit fields in Excel as they were forcibly using DisplayModelEditableText and now they were getting this class twice in the MRO. When trying to come up with a fix I've found another problems with the approach from #11966 namely edit fields which require UnidentifiedEdit weren't getting it in the MRO when they are initially empty.

Description of how this pull request fixes the issue:

Since we're quite close to the release it makes sense to revert #11966 for now and investigate another approach - the program for which the original fix was needed is quite niche and therefore I don't consider this to be a big loss. I'll try to come up with something better for the next release.

Testing strategy:

Asked reporter from #12402 to test - they have confirmed that the problem no longer occurs.

Known issues with pull request:

  • Edit fields in IDE's by MCS Electronic are not accessible.

Change log entries:

I've removed entry from #11966 as part of this PR.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

Linting failure is expected here as this just reverts the commit.

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner May 18, 2021 11:36
@lukaszgo1 lukaszgo1 requested review from seanbudd and removed request for a team May 18, 2021 11:36
@AppVeyorBot
Copy link

See test results for failed build of commit 3c97a226f5

@seanbudd seanbudd added this to the 2021.1 milestone May 18, 2021
@seanbudd
Copy link
Member

@michaelDCurran @feerrenrut I've added you as reviewers as I won't be able to merge this with the lint check fail.

@michaelDCurran michaelDCurran merged commit f442b9f into nvaccess:beta May 19, 2021
@lukaszgo1 lukaszgo1 deleted the I12402Revert branch May 19, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants