Revert PR 11966 to fix errors when interacting with edit fields in MS Excel #12429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opened against beta.
Link to issue number:
Work around for issue #12402
Summary of the issue:
PR #11966 started using
DisplayModelEditableText
for edit fields with empty window text to improve access to IDE's by MCS Electronic - this unfortunately broke access to some edit fields in Excel as they were forcibly usingDisplayModelEditableText
and now they were getting this class twice in the MRO. When trying to come up with a fix I've found another problems with the approach from #11966 namely edit fields which requireUnidentifiedEdit
weren't getting it in the MRO when they are initially empty.Description of how this pull request fixes the issue:
Since we're quite close to the release it makes sense to revert #11966 for now and investigate another approach - the program for which the original fix was needed is quite niche and therefore I don't consider this to be a big loss. I'll try to come up with something better for the next release.
Testing strategy:
Asked reporter from #12402 to test - they have confirmed that the problem no longer occurs.
Known issues with pull request:
Change log entries:
I've removed entry from #11966 as part of this PR.
Code Review Checklist:
Linting failure is expected here as this just reverts the commit.