Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR 11966 to fix errors when interacting with edit fields in MS Excel #12429

Merged
merged 1 commit into from May 19, 2021
Merged

Revert PR 11966 to fix errors when interacting with edit fields in MS Excel #12429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions source/NVDAObjects/window/__init__.py
View file
Open in desktop
@@ -1,7 +1,8 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2006-2020 NV Access Limited, Babbage B.V., Bill Dengler
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
#NVDAObjects/window.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2019 NV Access Limited, Babbage B.V., Bill Dengler
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.

import re
import ctypes
Expand Down Expand Up @@ -135,7 +136,7 @@ def findOverlayClasses(self,clsList):
if not any(issubclass(cls,EditableText) for cls in clsList):
gi=winUser.getGUIThreadInfo(self.windowThreadID)
if gi.hwndCaret==self.windowHandle and gi.flags&winUser.GUI_CARETBLINKING:
if self.windowTextLineCount and self.windowText:
if self.windowTextLineCount:
from .edit import UnidentifiedEdit
clsList.append(UnidentifiedEdit)
else:
Expand Down
1 change: 0 additions & 1 deletion user_docs/en/changes.t2t
View file
Open in desktop
Expand Up @@ -47,7 +47,6 @@ This release also drops support for Adobe Flash.
- The list of messages in Outlook 2010 is once again readable. (#12241)
- In terminal programs on Windows 10 version 1607 and later, when inserting or deleting characters in the middle of a line, the characters to the right of the caret are no longer read out. (#3200)
- This experimental fix must be manually enabled in NVDA's advanced settings panel by changing the diff algorithm to Diff Match Patch.
- Fixed access to edit fields in MCS Electronics IDE's. (#11966)
- In MS Outlook, inappropriate distance reporting when shift+tabbing from the message body to the subject field should not occur anymore. (#10254)
- In the Python Console, inserting a tab for indentation at the beginning of a non-empty input line and performing tab-completion in the middle of an input line are now supported. (#11532)
- Formatting information and other browseable messages no longer present unexpected blank lines when screen layout is turned off. (#12004)
Expand Down