Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump comtypes to 1.1.11 #12953

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Bump comtypes to 1.1.11 #12953

merged 7 commits into from
Jun 21, 2022

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Oct 18, 2021

Link to issue number:

None

Description of this pull request

Updates Comtypes to version 1.1.11.

Changelog

Release 1.1.11
--------------
 * Fix setuptools>=57.5.0 compatibility. Thanks @kdschlosser.
 * Fix timestamping for typelib. Thanks @fusentasticus.
 * Fix 64bit inproc server. Thanks @klusidy.
 * Drop Python 2.6 support (Python 2.7 is still supported).
 * Fix IndexError for empty safearray. Thanks @BALOGHBence.
 * Make numpy typecodes consistent across numpy versions. Thanks @bennyrowland.

Release 1.1.10
--------------
 * Fix loading module from relative path on Windows 7.

Release 1.1.9
-------------
 * Fix loading module from relative path.
 * Use comtypes release version in code generator version check.

Testing strategy:

Should run for a while in Alpha.

Known issues with pull request:

None known

Change log entries:

For Developers

  • Updated Comtypes to version 1.1.11.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@LeonarddeR LeonarddeR requested a review from a team as a code owner October 18, 2021 16:12
@AppVeyorBot
Copy link

See test results for failed build of commit 788ba87ab6

@LeonarddeR LeonarddeR marked this pull request as draft October 18, 2021 16:31
@OzancanKaratas
Copy link
Collaborator

@LeonarddeR please consider updating to version 1.1.11.

requirements.txt Outdated Show resolved Hide resolved
@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.10 Bump comtypes to 1.1.11 Feb 18, 2022
@LeonarddeR
Copy link
Collaborator Author

Thanks @OzancanKaratas

@AppVeyorBot
Copy link

See test results for failed build of commit b1e531b550

@OzancanKaratas
Copy link
Collaborator

A bug fix version (1.1.12) has been released.

@seanbudd
Copy link
Member

@LeonarddeR - what is holding this back from being merged?

@seanbudd seanbudd requested review from seanbudd and removed request for michaelDCurran June 21, 2022 02:44
@LeonarddeR LeonarddeR marked this pull request as ready for review June 21, 2022 05:46
@LeonarddeR
Copy link
Collaborator Author

In my opinion it would benefit from #13048. Now that's merged, I think we're good to go.

@seanbudd
Copy link
Member

@LeonarddeR - it appears there is a 1.1.12 now, should we update to that instead?

@LeonarddeR
Copy link
Collaborator Author

I hadn't seen that one, makes sense.

@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.11 Bump comtypes to 1.1.12 Jun 21, 2022
@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.12 Bump comtypes to 1.1.11 Jun 21, 2022
@LeonarddeR
Copy link
Collaborator Author

I'm seeing weird behavior with Comtypes 1.1.12 not populating com interfaces correctly. Furthermore, it's not available on PyPI. Lets stick to 1.1.11

@seanbudd
Copy link
Member

@LeonarddeR - I realise now that they are probably staged changes for a future 1.1.12 release, as the file linked is the changelog on master

@AppVeyorBot
Copy link

See test results for failed build of commit 1c803b5204

@AppVeyorBot
Copy link

See test results for failed build of commit 1c803b5204

@seanbudd seanbudd merged commit 713cdc0 into nvaccess:master Jun 21, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants