Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech Dictionary dialog: Add a "Remove all" button (#11802) taken over after abandoned #12385 #13294

Merged
merged 4 commits into from Feb 3, 2022
Merged

Speech Dictionary dialog: Add a "Remove all" button (#11802) taken over after abandoned #12385 #13294

merged 4 commits into from Feb 3, 2022

Commits on Feb 2, 2022

  1. Speech Dictionary dialogs: Split into their on gui.speechDict module 

    As a preparatory step for PR nvaccess#13294 the code should be moved from gui\settingsDialogs
    @JulienCochuyt @lukaszgo1
    JulienCochuyt authored and lukaszgo1 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    c112efa View commit details
    Browse the repository at this point in the history

  2. Convert line endings in gui\speechDict.py from CRLF to LF 

    In PR nvaccess#13294 it has been decided that LF is prefered for new files going forward.
    @JulienCochuyt @lukaszgo1
    JulienCochuyt authored and lukaszgo1 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    50d9d54 View commit details
    Browse the repository at this point in the history

  3. Lint source/gui/speechDict.py 

    As part of PR nvaccess#13294 speech dictionary dialogs were separated into their own module.
This commit makes the code in the new module compliant with our coding standards.
    @JulienCochuyt @lukaszgo1
    JulienCochuyt authored and lukaszgo1 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    668c6d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Speech Dictionary dialog: Add a "Remove all" button (nvaccess#11802) PR 

    nvaccess#13294

Link to issue number:
Fixes nvaccess#11802
Supersedes nvaccess#12385

Summary of the issue:
The Speech Dictionary dialog lacks a "Remove all" button to ease clearing a whole dictionary.

Description of how this pull request fixes the issue:
Split both the DictionaryDialog and DictionaryEntryDialog from gui.settingsDialogs to a new dedicated gui.speechDict
Redeem copyright holders' names by blaming the history of source/gui/settingsDialogs.py
Linted the result in a separate commit for easier review and history tracking
Added a "Remove all" coherent with the "Restore to factory default" as found on the Input Gestures dialog
    @JulienCochuyt @seanbudd
    JulienCochuyt authored and seanbudd committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    0bf6435 View commit details
    Browse the repository at this point in the history