Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up of PR 13805: No longer rely on star imports in appModule for MS Outlook #13811

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Jun 17, 2022

Link to issue number:

Fixes #13810

Summary of the issue:

PR #13805 removed star imports from NVDAObjects.IAccessible.winword. Unfortunately the appModule for MS Outlook relied on some of the stuff star imported there.

Description of user facing changes

MS Outlook can once again be used with Alpha versions of NVDA.

Description of development approach

Inspected all imports from NVDAObjects.IAccessible.winword - - where they imported stuff which is actually defined in NVDAObjects.window.winword the imports were made explicit.

Testing strategy:

Made sure that MS Outlook can once again be used

Known issues with pull request:

None known

Change log entries:

None needed - unreleased regression.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner June 17, 2022 17:08
@lukaszgo1 lukaszgo1 requested a review from seanbudd June 17, 2022 17:08
@seanbudd seanbudd merged commit 1d24f9b into nvaccess:master Jun 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jun 18, 2022
@lukaszgo1 lukaszgo1 deleted the I13810 branch June 18, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvda alpha most resents not reading anything when entering outlook
3 participants