Only show dev channel add-ons for pre-release NVDA #14693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For stable NVDA releases:
* this removes dev versions
Do I understand correctly, that for add-on developers who currently release new
features in dev versions, so that adventurous users can download and test these
in stable NVDA: stable NVDA users will not have access to these through
the store, even if the dev versions are in the store?
(I.e. such developers will need to devise an alternative distribution mechanism,
such as direct GitHub downloads)
If that is the case, may I suggest a feature flag or something to turn this back
on, for users who want it?
|
|
Do I understand correctly, that for add-on developers who currently release new
features in dev versions, so that adventurous users can download and test these
in stable NVDA: stable NVDA users will not have access to these through
the store, even if the dev versions are in the store?
This case you describe is what the beta channel is for.
We plan to allow channel selection in a future PR (to allow opting into
dev, opting out of stable/beta, etc)
|
|
Is there an impact for legacy add-ons, i.e. the ones migrated from addonFiles to addon-datastore? For some of them, the dev channel was used as what is now called beta channel in the add-on store. More general note:
|
|
Yes this seems to be reinventing the wheel to me. For example, systray list
add on has just got a new test version and the author wants it tested on
older Windows versions. Just as well as it fails to initialise at all on
Windows 7. Many add on authors wish to support things that NVDA newer
versions do not, and this seems to be complicating it all a bit.
Brian
…--
***@***.***
Sent via blueyonder.(Virgin media)
Please address personal E-mail to:-
***@***.***, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Cyrille Bougot" ***@***.***>
To: "nvaccess/nvda" ***@***.***>
Cc: "Subscribed" ***@***.***>
Sent: Friday, March 03, 2023 8:04 AM
Subject: Re: [nvaccess/nvda] Only show dev channel add-ons for pre-release
NVDA (PR #14693)
Is there an impact for legacy add-ons, i.e. the ones migrated from
addonFiles to addon-datastore? For some of them, the dev channel was used
as what is now called beta channel in the add-on store.
More general note:
With the add-on store some terms have slightly changed their meaning with
respect to what was used in the add-on community and on the [NVDA
Community Add-ons website](https://addons.nvda-project.org/index.en.html):
* "legacy":
* community website: add-ons declared end-of-life or not compatible with
last NVDA version
* add-on store: add-ons that were migrated from addonFiles to
addon-dataStore
* "dev channel":
* community website: a channel for early adopters; this covers both the
new beta and dev channels of the add-on store
* add-on datastore: a channel for add-ons working with alpha version of
NVDA even when API-breaking NVDA release dev cycle is on-going
--
Reply to this email directly or view it on GitHub:
#14693 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
We've decided to close this, in favour of allowing any add-on version compatibility check to be manually overwritten. The documentation proposed in nvaccess/addon-datastore#109 has been updated to match this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes nvaccess/addon-datastore-transform#15
Summary of the issue:
The "dev" channel is designed to be used for pre-release versions of NVDA only, and allow installation to incompatible API versions.
Description of user facing changes
Makes "dev" channel add-ons always compatible with pre-release versions of NVDA
Filters incompatible add-ons from the add-on store.
For stable NVDA releases:
For NVDA pre-releases:
Description of development approach
Check the channel when checking addon compatibility.
filter compatible add-on versions in the main view of the store.
Testing strategy:
Test add-on store views for stable and pre-release NVDA, by changing
buildVersionKnown issues with pull request:
None
Change log entries:
None
Code Review Checklist: