Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made two messages translatable. #14751

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

Reported on the translator's mailing list in this thread.

Summary of the issue:

PR #13798 introduced paragraph navigation in documents. Unfortunately two message added by this PR are not translatable: "No next/previous paragraph" since the gettext (_) function call has been forgotten; the translators comments are already there though.

Description of user facing changes

The message will be translatable

Description of development approach

Just added the call to the gettext function (_).

Testing strategy:

Manual:
Generate a .pot, merge to .po in French, translate it and use it with the feature.

Known issues with pull request:

While at it, I have searched for other occurrences of ui.message called with untranslated content. In NVDAObjects/IAccessible/winword.py, in the script script_reportCurrentHeaders, I have found:
ui.message("Row %s, column %s"%(rowText or "empty",columnText or "empty"))

I have not fixed this as this script is a half buggy, half debug and undocumented script (see #11465 for details).

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

Cc @rob-aph

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 27, 2023 13:47
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 27, 2023 13:47
@seanbudd seanbudd merged commit 0578158 into nvaccess:master Mar 28, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Mar 28, 2023
@CyrilleB79 CyrilleB79 deleted the makeMsgTranslatable branch March 29, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants