Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on store: consider 'blocked' when filtering enabled/disabled #15419

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 11, 2023

Link to issue number:

Fixes #15416

Summary of the issue:

When enabling/disabling an incompatible add-on, it is not filtered correctly when toggling filter by enabled/disabled status

Description of user facing changes

Fix bug described in #15416
Add-ons blocked due to compatibility reasons should now be filtered correctly when toggling the filter for enabled/disabled status.

Description of development approach

add additional checks for 'blocked' status when filtering enabled/disabled

Testing strategy:

Manually test disabling and enabling add-ons

Known issues with pull request:

None

Change log entries:

Bug fixes
Add-ons blocked due to compatibility reasons should now be filtered correctly when toggling the filter for enabled/disabled status. (#15416)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 11, 2023 06:09
@seanbudd seanbudd changed the base branch from master to beta September 11, 2023 06:09
@seanbudd seanbudd added this to the 2023.3 milestone Sep 11, 2023
michaelDCurran
michaelDCurran previously approved these changes Sep 11, 2023
@seanbudd seanbudd merged commit dafff7f into beta Sep 11, 2023
1 check was pending
@seanbudd seanbudd deleted the fix-15416 branch September 11, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-on Store: Add-ons that were disabled due to incompatibility with NVDA are filtered to enabled
2 participants