Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symbols.dic #16310

Merged
merged 1 commit into from Apr 9, 2024
Merged

Update symbols.dic #16310

merged 1 commit into from Apr 9, 2024

Conversation

smbgsrini
Copy link
Contributor

@smbgsrini smbgsrini commented Mar 15, 2024

Added some Kannada symbols

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Added some symbols
@smbgsrini smbgsrini requested a review from a team as a code owner March 15, 2024 09:19
@CyrilleB79
Copy link
Collaborator

Hello @smbgsrini

Thanks for wanting to contribute to NVDA.

Regarding translation of symbols (this PR) and characters (PR #16308), the current process is to translate through a specific Assembla repository dedicated to translation, not through GitHub.
At least this was the process until NVDA 2024.1 for which the translation period ends on next Monday.

Thus, it seems to me a bit late to integrate the changes of a new contributor until Monday.

The translation framework is currently evolving and we do not yet know how character and symbol files will be translated for NVDA 2024.2.

Thus I'd recommend that you subscribe to the translators mailing list. There you can write to the list to present yourself and try to get in touch with the current Kannada translator if any.
Though, looking at SVN repo history in kn folder, it seems that Kannada has not been updated for a long time, so maybe the translator is not active anymore.

Once you are subscribed to the list, you will be able to follow the discussions on the translation framework transition during NVDA 2024.2 dev cycle and you will be informed along with other people on how character and symbol translation will be processed.

Note also that sending a first e-mail to the list will allow you to pass the first moderation (only required for the first message); this will allow your subsequent messages not to be retained for moderation.

Cheers,

Cyrille

@CyrilleB79
Copy link
Collaborator

Regarding the current PR, unless NV Access says otherwise, let's keep it open until we know precisely how translation of caracters and symbols work in NVDA 2024.2.

@michaelDCurran
Copy link
Member

For now, we will take symbols and characterDescriptions here (via Github pull request).

@michaelDCurran michaelDCurran merged commit 2a8ca7e into nvaccess:master Apr 9, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants