Skip to content

Update characterDescriptions.dic#16308

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
smbgsrini:patch-3
Apr 10, 2024
Merged

Update characterDescriptions.dic#16308
michaelDCurran merged 1 commit into
nvaccess:masterfrom
smbgsrini:patch-3

Conversation

@smbgsrini
Copy link
Copy Markdown
Contributor

@smbgsrini smbgsrini commented Mar 15, 2024

Link to issue number:

Summary of the issue:

Kannada characters discription

Description of user facing changes

Added Braille Code for each Characters

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

added Braille codes for each characters
@smbgsrini smbgsrini requested a review from a team as a code owner March 15, 2024 08:51
@smbgsrini smbgsrini requested a review from gerald-hartig March 15, 2024 08:51
@CyrilleB79 CyrilleB79 mentioned this pull request Mar 15, 2024
5 tasks
@CyrilleB79
Copy link
Copy Markdown
Contributor

This PR is blocked until due to translation framework current changes; see #16310 (comment) for details.

As per #16310, regarding the current PR, unless NV Access says otherwise, let's keep it open until we know precisely how translation of caracters and symbols work in NVDA 2024.2.

@michaelDCurran
Copy link
Copy Markdown
Member

For now we will take symbols and character descriptions here (via Github pull request).
@smbgsrini Can you further explain why you have added braille descriptions for each character? I guess I can sort of see how this can help disambiguate characters via another known modality such as Braille, it is just I have never seen any other language do this so far. Has this been done in any other screen reader in the past?

@smbgsrini
Copy link
Copy Markdown
Contributor Author

smbgsrini commented Apr 10, 2024 via email

@michaelDCurran michaelDCurran merged commit 0889076 into nvaccess:master Apr 10, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants