Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vertical, style and text QuickNav commands in Kindle #16571

Merged
merged 1 commit into from
May 20, 2024

Conversation

mltony
Copy link
Contributor

@mltony mltony commented May 18, 2024

Link to issue number:

Closes #16559
Closes #16558

Summary of the issue:

Fancy QuickNav commands (style navigation, text navigation, vertical navigation) don't work correctly in Kindle desktop app.

Description of user facing changes

Fancy quickNav commands will be disabled in Kindle.

Description of development approach

Throwing a NotImplementedException.

Testing strategy:

Manual

Known issues with pull request:

N/A

More details

Root cause issue: #16570

Code Review Checklist:

  • x ] Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony changed the base branch from master to beta May 18, 2024 00:24
@mltony mltony marked this pull request as ready for review May 18, 2024 00:25
@mltony mltony requested a review from a team as a code owner May 18, 2024 00:25
@mltony mltony requested review from seanbudd and removed request for a team May 18, 2024 00:25
@Adriani90
Copy link
Collaborator

Adriani90 commented May 18, 2024

@mltony please don‘t disable vertical nav, this one works properly in Kindle and is very useful. Or do you get certain errors when using vertical nav?Thanks.

@mltony
Copy link
Contributor Author

mltony commented May 18, 2024

But vertical nav relies on the same function _moveToNextParagraph that according to my testing gets stuck in Kindle. Try using vertical nav in the same test case where your text nav keystroke caused NVDA to hang - I think vertical Nav would hang as well.

@seanbudd seanbudd added this to the 2024.2 milestone May 20, 2024
@seanbudd seanbudd merged commit 0ef57b1 into nvaccess:beta May 20, 2024
1 check passed
@seanbudd
Copy link
Member

Thanks @mltony

seanbudd pushed a commit that referenced this pull request May 20, 2024
Closes #16559
Closes #16558

Summary of the issue:
Fancy QuickNav commands (style navigation, text navigation, vertical navigation) don't work correctly in Kindle desktop app.

Description of user facing changes
Fancy quickNav commands will be disabled in Kindle.

Description of development approach
Throwing a NotImplementedException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable text style navigation in Kindle Text paragraph navigation: NVDA crashes in Kindle
3 participants