Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in User Guide for beta #16822

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fixes in User Guide for beta #16822

merged 2 commits into from
Jul 8, 2024

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Jul 4, 2024

Link to issue number:

None

Summary of the issue:

Some fixes seen in NVDA's user guide during translation.

Description of user facing changes

See User Guide

Description of development approach

N/A

Testing strategy:

Check generated user guide

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Summary by CodeRabbit

  • Documentation
    • Added a requirement of at least 4 GB of RAM.
    • Clarified the representation of special characters like "ü".
    • Updated a notification option label from "Enabled" to "Notify".
    • Revised the description for creating a portable copy of the application.

Copy link
Collaborator Author

@CyrilleB79 CyrilleB79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added additional explanations where the modifications have been done.

user_docs/en/userGuide.md Outdated Show resolved Hide resolved
@@ -1916,7 +1917,7 @@ For example, the latin letter "h" can also be presented as "𝐡" (bold), "ℎ"
This aspect of normalization also aids in reading equations in the Microsoft Word equation editor.

1. Normalization to composed characters.
For example, the character "ü" (u with umlaut/diaeresis), a common character in languages like German and Turkish can be represented in two forms.
For example, the character "ü" (u with umlaut/diaeresis), a common character in languages like German and Turkish can be represented in two forms:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colon to announce the following 2-item list.

This will open a dialog which allows you to create a portable copy of NVDA out of the installed version.

The dialog to create a portable copy of NVDA or to install NVDA on this PC will prompt you to choose a folder path in which NVDA should create the portable copy or in which NVDA should be installed.
This will open a dialog which allows you to create a portable copy of NVDA out of the currently running version.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken, creating a portable copy from another portable one or from the temporary copy of the installer use the currently running copy as source, not the installed copy (which may not exist by the way).

@@ -3656,9 +3657,7 @@ For more information, read the in-depth section: [Add-ons and the Add-on Store](

### Create portable copy {#CreatePortableCopy}

This will open a dialog which allows you to create a portable copy of NVDA out of the installed version.

The dialog to create a portable copy of NVDA or to install NVDA on this PC will prompt you to choose a folder path in which NVDA should create the portable copy or in which NVDA should be installed.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this line because:

  • Now that we have linked below a detailed paragraph about portable copy creation including the description of the dialog, describing the dialog here is not needed anymore.
  • this line also mentions NVDA's installation whereas the current paragraph is about portable copy creation.

@@ -3656,9 +3657,7 @@ For more information, read the in-depth section: [Add-ons and the Add-on Store](

### Create portable copy {#CreatePortableCopy}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before 2024.3beta1, this paragraph was mentioning more or less the case where NVDA can be installed from the tools menu of a portable (or temporary) copy.

This is now less the case, and actually all the references to NVDA's installation are being removed from this paragraph in this PR.

To make things clear, we should create a dedicated paragraph "Install NVDA".to describe this item from the Tools submenu, with a link to the detailed paragraph about installation. Can it be accepted here or should I do it in another PR against master (i.e. for 2024.4)?

@seanbudd seanbudd added this to the 2024.3 milestone Jul 5, 2024
@CyrilleB79 CyrilleB79 marked this pull request as ready for review July 5, 2024 06:52
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner July 5, 2024 06:52
@CyrilleB79 CyrilleB79 requested review from Qchristensen and removed request for a team July 5, 2024 06:52
Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Walkthrough

The recent updates to the userGuide.md include specifying a minimum requirement of 4 GB of RAM, better explanations for character representations such as "ü", updating a notification label from "Enabled" to "Notify", and refining the instructions for creating a portable copy of NVDA. These adjustments enhance clarity and usability without altering any public or exported entities.

Changes

File Change Summary
user_docs/.../userGuide.md Added RAM requirement, clarified character representation, updated notification option label, revised portable copy instructions

Sequence Diagram(s)

No sequence diagrams required for these documentation changes.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
user_docs/en/userGuide.md (2)

54-54: Ensure Consistency in System Requirements Presentation

The addition of the RAM requirement is clear. However, ensure that both the recommended and minimum system requirements sections consistently mention RAM.


2948-2948: Ensure Consistency in Terminology

The label change from "Enabled" to "Notify" is clear. Ensure this change is consistently applied throughout the document wherever this option is referenced.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit d4cf960 into nvaccess:beta Jul 8, 2024
1 check was pending
@CyrilleB79 CyrilleB79 deleted the ugFixes branch July 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants