Table for the international phonetic alphabet #16829
Conversation
WalkthroughIn this update, a new Braille table for the International Phonetic Alphabet (IPA) was added to Changes
Sequence Diagram(s)1. Adding a new Braille TablesequenceDiagram
participant Developer
participant BrailleTables
participant UserDocs
Developer->>BrailleTables: Add "IPA.utb" Braille table
Developer->>UserDocs: Update changes.md to include IPA Braille table
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
user_docs/en/changes.md (3)
18-20: Correct the punctuation and improve readability.There is an extra comma after "ancient languages" and the term "International phonetic alphabet" should be capitalized.
- Liblouis has been updated, adding new Braille tables for Cyrillic Serbian, Yiddish, several ancient languages,, Turkish, and International phonetic alphabet. + Liblouis has been updated, adding new Braille tables for Cyrillic Serbian, Yiddish, several ancient languages, Turkish, and International Phonetic Alphabet.
18-20: Ensure consistent formatting for new entries.The new additions should follow the one sentence per line format for better readability and consistency.
- eSpeak has been updated, adding support for the Karakalpak language. - Unicode CLDR has also been updated. + eSpeak has been updated, adding support for the Karakalpak language. + Unicode CLDR has also been updated.
49-49: Ensure consistent capitalization and punctuation.The term "International phonetic alphabet" should be capitalized, and the entry should end with a period.
- * International phonetic alphabet. (#16773) + * International Phonetic Alphabet. (#16773)
|
Maybe my question is naive. But why wouldn't a user be able to write IPA braille, e.g. to write the phonetic transcription of a word. Of course, it's quite unlikely that a user writes a long text in IPA. But wouldn't a user want to configure a specific profile to enable only to write phonetic transcriptions? Cc @josephsl |
@seanbudd, I can see that you have just merged this PR. Would you be able to answer this question? I.e. why not include this table for input? |
|
Hi @CyrilleB79 |
|
OK @zstanecic. If a specialist need this, they will probably ask it. |
Link to issue number:
fixes #16773
Summary of the issue:
This pull request adds the International phonetic alphabet braille table inly on output, as requested in the issue referenced above.
Description of user facing changes
Added new International phonetic alphabet braille table in the braille settings dialog, output braille table section
Description of development approach
Changed the brailleTables.py and changes.t2t accordingly, all this based on the beta branch, targeted to 2024.3
Testing strategy:
Ran NVDA from source and verified that the braille table works.
Known issues with pull request:
None known
Code Review Checklist:
Summary by CodeRabbit
New Features
Documentation