Add appmodule for 64-bit version of Media Player Classic #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonarddeR
previously approved these changes
Jun 4, 2018
source/appModules/mpc-hc64.py
Outdated
| # Copyright (C) 2018 NV Access Limited, Łukasz Golonka | ||
| # This file may be used under the terms of the GNU General Public License, version 2 or later. | ||
| # For more details see: https://www.gnu.org/licenses/gpl-2.0.html | ||
| from mplayerc import * |
There was a problem hiding this comment.
Could you please add an empty line before and after this line?
|
@LeonarddeR I believe I've addressed your commends. Is your approval enough to incubate this or something else needs to be done? |
|
Yes, I think it is safe to incubate this, as it is a very small change. Could you please merge in most recent master before this will be merged into master in around a week or two? |
michaelDCurran
previously approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6066
Summary of the issue:
NVDA has an app module for MPC-HC, but only for 32-bit version.
Description of how this pull request fixes the issue:
I've created an app module for 64-bit version of MPC-HC which simply uses a 32-bit app module.
Testing performed:
Tested that status bar is properly recognized in 64--bit version of MPC-HC and that app module is loading.
Known issues with pull request:
None
Change log entry:
The 64-bit version of Media Player Classic is now supported.