Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ia2utils HyperlinkGetter: Switch to CComPtr #9152
Link to issue number:
Addresses part of #9133.
Summary of the issue:
When rendering a document for browse mode in Firefox, failure in retrieving an embedded object causes an uncaught exception, thus crashing Firefox. See this Firefox crash report.
Description of how this pull request fixes the issue:
HyperlinkGetter (in nvdaHelper/common/ia2utils) uses the
We had the choice to switch to CComPtr (which guarantees not to throw exceptions) or catch the exceptions. Since we're moving to CComPtr in newer code anyway, I went with the former.
Tested rendering World War I in Firefox and compared the load times to check they were in the same ballpark. I can't test for the crash, since I can't reproduce it and it is very rare.
Known issues with pull request:
Change log entry: