Python 3: use importlib for importing modules #9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelDCurran
approved these changes
Jun 8, 2019
feerrenrut
reviewed
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Reworked version of a previous PR:
Link to issue number:
Fixes #8768
Summary of the issue:
Uses importlib for importing modules instead of using import function.
Description of how this pull request fixes the issue:
Same as a reverted PR but only concerns importlib. This affects IAccessible objects, app modules, braille display drivers, global plugin handler and synth drivers.
Also, unlike previous PR, this one is strictly Python 3 - no encoding/decoding done.
Testing performed:
Tested with source code copy (Python 2 and 3).
Known issues with pull request:
Possible Unicode-related issues may surface.
Change log entry:
None