Fix bower management command for Django 1.10 #66
Conversation
|
@freeyoung: Could you please fix the tests (merging with current master might be enough) and add Django 1.10 to the .travis.yml? |
|
@PetrDlouhy Sure! I will give it a look today. |
|
@PetrDlouhy I've fixed the tests for django >= 1.8. However for lower versions of django I could not really fix the tests because django 1.8 changed the way to implement custom management commands. Now that django versions < 1.8 have reached the end of support since December 2015, I propose to remove these versions from |
|
I am not maintainer of this repository, so we should ask @nvbn if it is possible to drop the support. |
| @@ -19,7 +19,7 @@ def _check_bower_exists(self): | |||
| if not bower_adapter.is_bower_exists(): | |||
| raise BowerNotInstalled() | |||
|
|
|||
| def _install(self, args): | |||
| def _install(self, args=[]): | |||
There was a problem hiding this comment.
It should be:
def _install(self, args=None):
if args is None:
args = []
|
+1, supporting 1.4 is a waste of time imo... |
|
Since #71 has been merged, closing. |
No description provided.