Add nushell support #1442
Open
Add nushell support #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afresquet
force-pushed
the
nushell-support
branch
from
e8b3ccc
to
ed084cf
Compare
|
CC @scorphus Hopefully it's okay to ping you as I see you've made the last release :) |
|
Just tested it on my machine. Nice work! |
Skyppex
reviewed
May 11, 2024
Comment on lines
+13
to
+25
| def get_aliases(self): | ||
| aliases = {} | ||
| command = 'help aliases | select name expansion | each { |row| $row.name + " ; " + $row.expansion } | str join (char nl)' | ||
| proc = Popen(['nu', '-l', '-c', command], stdout=PIPE, stderr=DEVNULL) | ||
| if proc.stdout is None: | ||
| return aliases | ||
| alias_out = proc.stdout.read().decode('utf-8').strip() | ||
| for alias in alias_out.split('\n'): | ||
| split_alias = alias.split(" ; ") | ||
| if len(split_alias) == 2: | ||
| name, value = split_alias | ||
| aliases[name] = value | ||
| return aliases |
There was a problem hiding this comment.
Would it be possible to get all the commands in nushell aswell using help commands in here?
help aliases only gets the actual aliases, i.e, stuff like alias vim = nvim.
There was a problem hiding this comment.
sweet, this will be awesome when its working merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441 #1254
The real issue wasn't the missing
Nushellclass, but rathersys.stdout.writefailing to makenushellrun the command.I've fixed that by running a
subprocess, however it lacks access to any config/env that is set in the current session, it could be fixed by adding an-lflag to the command, but that will also run anything that run on login (likeneofetch).Still, also added a
Nushellclass with the relevant overrides.What do you think @nvbn ? Anything that could be changed let me know, it's my first time writing Python so I'm sure there are things that could be done better