Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid for_app/sudo_support ordering #861

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

chrisdepas
Copy link
Contributor

@chrisdepas chrisdepas commented Dec 8, 2018

  • Fixed incorrect ordering of for_app/sudo_support annotations causing apt_invalid_operation and dnf_no_such_command rules to fail
  • The previous ordering meant that for_app was on the inside (i.e. called first), so it would fail for commands executed with sudo

…lid_operation and dnf_no_such_command rules to fail
@chrisdepas chrisdepas changed the title Fix invalid for_app/sudo_supprot ordering Fix invalid for_app/sudo_support ordering Dec 8, 2018
@nvbn
Copy link
Owner

nvbn commented Dec 11, 2018

Thanks!

@nvbn nvbn merged commit 7bc6193 into nvbn:master Dec 11, 2018
@chrisdepas chrisdepas deleted the hotfix/SudoSupportForAppOrder branch December 20, 2018 09:18
riley-martine pushed a commit to riley-martine/thefuck that referenced this pull request Dec 7, 2023
…lid_operation and dnf_no_such_command rules to fail (nvbn#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants