Fix-up of #28 to handle the situation when there are no existing translations. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting translations. Pr nvdaaddons#28 included moFile in the dependency for HTML file generation. However if there was no moFile set, likely because there has not been any translation yet, sconstruct failed on a NameError. To solve this, I put the access of moFile in a try-except-else block.
XLTechie
force-pushed
the
fixSconstructForNoTranslations
branch
from
7f93175
to
6663b5c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 included moFile in the dependency for HTML file generation.
However if there was no moFile set, likely because there has not been any translation yet, sconstruct failed on a NameError.
To solve this, I put the access of moFile in a try-except-else block.