-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wasm] Add TextBlock measure caching #931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
added
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
kind/performance
labels
May 26, 2019
MatFillion
approved these changes
May 28, 2019
dr1rrb
approved these changes
May 28, 2019
jeromelaban
force-pushed
the
dev/jela/wasm-tb-perf
branch
from
May 28, 2019 01:23
9900cee
to
3fb69aa
Compare
carldebilly
approved these changes
May 28, 2019
jeromelaban
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
May 28, 2019
jeromelaban
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Add basic TextBlock measure caching to reduce the number of JS measureView invocations.
Same text measure time is divided by 2 using the interpreter.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):