Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm] Add TextBlock measure caching #931

Merged
merged 10 commits into from
May 28, 2019
Merged

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented May 26, 2019

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

Add basic TextBlock measure caching to reduce the number of JS measureView invocations.

Same text measure time is divided by 2 using the interpreter.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@jeromelaban jeromelaban added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform kind/performance labels May 26, 2019
@jeromelaban jeromelaban marked this pull request as ready for review May 28, 2019 00:54
@jeromelaban jeromelaban added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2019
@jeromelaban jeromelaban merged commit 6135176 into master May 28, 2019
@jeromelaban jeromelaban removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2019
@carldebilly carldebilly deleted the dev/jela/wasm-tb-perf branch June 3, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants