-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add luarocks upload release workflow #435
Conversation
c3bad26
to
75848b8
Compare
Doing that is a really good idea, thank you. If it works we can also do the same in telescope, what do you think? |
Yes, adding it to telescope would be the next step 😄 |
So i've added a I hope it just works :) Thank you very much for writing that :) |
huh, sad life 😆 https://github.com/nvim-lua/plenary.nvim/actions/runs/3855064722/jobs/6569723106 I'll gonna drop that tag again, so we can test multiple times with v0.1.1 😆 |
No problem. I really like teto's idea, and want to help it take off. Let me know if it doesn't work. Then I'll create a playground repo to fix it. |
Yeah it didn't work: https://github.com/nvim-lua/plenary.nvim/actions/runs/3855064722/jobs/6569723106 |
🤔 that looks like the workflow may be calling make from the wrong directory for some reason. |
I know whats missing. you forgot a checkout action: happens ^^ |
@Conni2461 I will be starting work on a Github workflow for the marketplace today, to make it easier for plugin maintainers to add it to their repos (maybe without having to add a rockspec). Would you be interested in hosting it on nvim-lua? It would probably reach more people than if I host it on my profile. |
I am not a nvim-lua org member so i cant make that decision but i like the idea. I poked tj about |
The first draft is ready and it seems to be working 🚀 |
@Conni2461
see nvim-telescope/telescope.nvim#2276 (comment).
The upload script expects a
LUAROCKS_API_KEY
. It should be possible to set it as one of this repo's GitHub Actions secrets.I have tested
make luarocks_upload
and it seems to work, but I cannot test this with GitHub Actions. The lua/luarocks install tasks fail when run locally with act, but maybe they will succeed on GitHub.