Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add luarocks upload release workflow #435

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Jan 3, 2023

@Conni2461

see nvim-telescope/telescope.nvim#2276 (comment).

The upload script expects a LUAROCKS_API_KEY. It should be possible to set it as one of this repo's GitHub Actions secrets.

I have tested make luarocks_upload and it seems to work, but I cannot test this with GitHub Actions. The lua/luarocks install tasks fail when run locally with act, but maybe they will succeed on GitHub.

@Conni2461
Copy link
Collaborator

Doing that is a really good idea, thank you. If it works we can also do the same in telescope, what do you think?

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jan 6, 2023

Yes, adding it to telescope would be the next step 😄

@Conni2461
Copy link
Collaborator

So i've added a LUAROCKS_API_KEY, so lets try it out. I'll merge and tag a new version 0.1.1.

I hope it just works :) Thank you very much for writing that :)

@Conni2461 Conni2461 merged commit 345092e into nvim-lua:master Jan 6, 2023
@Conni2461
Copy link
Collaborator

huh, sad life 😆

https://github.com/nvim-lua/plenary.nvim/actions/runs/3855064722/jobs/6569723106

I'll gonna drop that tag again, so we can test multiple times with v0.1.1 😆

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jan 6, 2023

No problem. I really like teto's idea, and want to help it take off.

Let me know if it doesn't work. Then I'll create a playground repo to fix it.

@Conni2461
Copy link
Collaborator

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jan 6, 2023

huh, sad life laughing

https://github.com/nvim-lua/plenary.nvim/actions/runs/3855064722/jobs/6569723106

I'll gonna drop that tag again, so we can test multiple times with v0.1.1 laughing

🤔 that looks like the workflow may be calling make from the wrong directory for some reason.

@Conni2461
Copy link
Collaborator

Conni2461 commented Jan 6, 2023

I know whats missing. you forgot a checkout action: uses: actions/checkout@v3

happens ^^

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jan 13, 2023

@Conni2461 I will be starting work on a Github workflow for the marketplace today, to make it easier for plugin maintainers to add it to their repos (maybe without having to add a rockspec).

Would you be interested in hosting it on nvim-lua? It would probably reach more people than if I host it on my profile.

@Conni2461
Copy link
Collaborator

I am not a nvim-lua org member so i cant make that decision but i like the idea. I poked tj about

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jan 13, 2023

I am not a nvim-lua org member so i cant make that decision but i like the idea. I poked tj about

The first draft is ready and it seems to be working 🚀

Luarocks release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants