feat(icon): file & folder symlink icon (related to #910) #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miversen33
approved these changes
Aug 25, 2023
cseickel
reviewed
Aug 25, 2023
lua/neo-tree/defaults.lua
Outdated
| @@ -200,6 +200,8 @@ local config = { | |||
| folder_open = "", | |||
| folder_empty = "", | |||
| folder_empty_open = "", | |||
| folder_symlink = "", | |||
| file_symlink = "", | |||
There was a problem hiding this comment.
This link is almost impossible for me to distinguish from the standard "unknown file" icon. Can we find one that's more obvious?
There was a problem hiding this comment.
Also, I'm not entirely sure I even want a default icon set for this. Some people might want to see the target's icon and not a generic symlink icon.
| @@ -275,7 +275,11 @@ M.icon = function(config, node, state) | |||
| elseif node:is_expanded() then | |||
| icon = config.folder_open or "-" | |||
There was a problem hiding this comment.
I realize this problem pre-existed, but now I see that it doesn't make sense that there is only a symlink icon for closed dirs and not open ones. This should be fixed.
| @@ -275,7 +275,11 @@ M.icon = function(config, node, state) | |||
| elseif node:is_expanded() then | |||
| icon = config.folder_open or "-" | |||
| else | |||
| icon = config.folder_closed or "+" | |||
| if node.is_link then | |||
| icon = config.folder_symlink | |||
There was a problem hiding this comment.
Suggested change
| icon = config.folder_symlink | |
| icon = config.folder_symlink or config.folder_closed or "+" |
This needs fallbacks.
| @@ -284,6 +288,9 @@ M.icon = function(config, node, state) | |||
| icon = devicon or icon | |||
| highlight = hl or highlight | |||
| end | |||
| if node.is_link then | |||
There was a problem hiding this comment.
Suggested change
| if node.is_link then | |
| if node.is_link and config.file_symlink then |
What if someone sets this to nil because they don't want to show a symlink icon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.