Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for concealing the link modifier,
:
. Since tree-sitter will not allow us to do concealing natively we will have to rely on our trusty Vim syntax regions defined via regexes anyways.Actual text
Concealed
Up for discussion
Right now, I implemented the link modifier regex to only require being suff- and prefixed with another markup modifier on the opening and closing link modifiers, respectively. However, this somewhat contradicts the current spec which requires a non-whitespace character in front of the opening modifier. However, I find that is a limitation because it will prevent e.g. the following:
This is :*im*:possible!
I believe, that this is a not uncommon scenario so I am open for suggestions on how to rephrase the spec accordingly. I placed a temporary TODO comment at the relevant position of the markdown file.
As of right now, the spec does not contain a similar limitation for the closing
:
.PS: I also did some minor touch-ups on the other conceal elements