fix: fixed icon highlights #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folke
changed the title
|
Thanks :) |
|
Thank you for the quick merge! :) |
Conni2461
pushed a commit
that referenced
this pull request
May 24, 2023
(cherry picked from commit 057ee0f)
abelmul
pushed a commit
to abelmul/telescope.nvim
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two locations where icons were highlighted at index
1.Highlight indices start at
0, so that was wrong.What happened instead is that the highlight started inside a multi-byte character. That behavior is undefined.
That used to work accidentally, but with the virtual text PR, icons are broken on nightly.
neovim/neovim#20130
This PR fixes the highlight offsets.
Checklist: