Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multichar offset issue #466

Closed
wants to merge 1 commit into from
Closed

Fix multichar offset issue #466

wants to merge 1 commit into from

Conversation

Owen000
Copy link

@Owen000 Owen000 commented Jul 7, 2024

#465

This address the above issue, I'm not 100% confident on why this works but it does. I've done quite a bit of testing and see no downsides to this fix.

@polirritmico
Copy link
Contributor

Hi, the problem with this approach is that sometimes when resizing small windows sizes, the col position minus the offset could be negative instead of 0, throwing an error. Its difficult to reproduce it but it happens (check #461).

I've try it with #470 and work without problems.

@Owen000 Owen000 closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants