Resolve issue deleting special files and folders, like .git #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
Nov 8, 2020
david-poindexter
added a commit
that referenced
this pull request
Nov 22, 2020
* Refactor Project (#259) * Refactor phase one * Refactor phase two * Refactor phase three * Resolve issue deleting special files and folders, like .git (#261) * Add check for online connectivity and logic based on that check (#262) * Adds stylecop and fxcop to the project (#263) * - Implemented fxcop - Implemented stylecop - Refactored DatabaseController - Did some automated fixed on whole project * Implemented the rest of the stylecop/fxcop warning * Add SQL Server Authentication User Name to user settings for rememberance (#264) * Standardize all dialogs (#265) * Add custom YesNo message box and replace all default YesNo MessageBox implementations * Add custom OK message box and refactor * Move custom message box controls to new namespace * Add folders for Exceptions classes (#267) * Adds option to delete existing sites (#268) Allows deleting sites create by nvQuickSite togehter with the database and files and hosts file entry, etc. * Resolves cursor appearance issue for the View Existing Sites button (#270) * Updated ViewExistingSites to refine the design (#272) * Add setting for enabling the ability to install local packages (#273) * Implemented logging in application (#274) * Implemented logging in application - Adds basic logging in most crytical code paths - Adds ability to change logging level at runtime without restarting the app - Does not remember the log level currently between runs, this is easy to change, I was debating either to implement this or not. - Set to log Information level so logs informational things as well as errors by default. - Raising the level to Debug or more will log more granular information * Fixed an issue that prevented setting log levels * Update nvQuickSite/Controllers/DatabaseController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/DatabaseController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Program.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/VersionController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Refine User Settings UI and fix casing for Logs folder (#277) * Disable min, max, resize for dialogs and move User Settings, View Existing Sites, Delete Sites to Controls namespace (#281) * Allows deleting a site that is not started (#286) Closes #282 - Refactored some methods to not mix reusable logic with the UI focused classes. - Added more logging in the sites deletion code paths. - Reworked site and appPool stopping logic to avoid throwing exceptions on states that don't prevent the site deletion. * Move logging of user settings values to DBG instead of INF (#287) * Adds a link to the logs folder in the settings (#289) * Adds a link to the logs folder in the settings This allows users easy access to the logs * Renamed link for clarity * Fixes Typo and adjust logging (#290) - Fixes a typo in last step - Removes unused usings - Adjusts file deletion logging to not log too much in default level (get's called recursifvelly) * Add winget manifest for 1.4.2 (#291) * Improve visual and placement of View Logs feature and utilize Hand cursor where appropriate (#294) * Update version number to 2.0.0 (#295) Co-authored-by: Daniel Valadas <info@danielvaladas.com>
david-poindexter
added a commit
that referenced
this pull request
Nov 29, 2020
* Refactor Project (#259) * Refactor phase one * Refactor phase two * Refactor phase three * Resolve issue deleting special files and folders, like .git (#261) * Add check for online connectivity and logic based on that check (#262) * Adds stylecop and fxcop to the project (#263) * - Implemented fxcop - Implemented stylecop - Refactored DatabaseController - Did some automated fixed on whole project * Implemented the rest of the stylecop/fxcop warning * Add SQL Server Authentication User Name to user settings for rememberance (#264) * Standardize all dialogs (#265) * Add custom YesNo message box and replace all default YesNo MessageBox implementations * Add custom OK message box and refactor * Move custom message box controls to new namespace * Add folders for Exceptions classes (#267) * Adds option to delete existing sites (#268) Allows deleting sites create by nvQuickSite togehter with the database and files and hosts file entry, etc. * Resolves cursor appearance issue for the View Existing Sites button (#270) * Updated ViewExistingSites to refine the design (#272) * Add setting for enabling the ability to install local packages (#273) * Implemented logging in application (#274) * Implemented logging in application - Adds basic logging in most crytical code paths - Adds ability to change logging level at runtime without restarting the app - Does not remember the log level currently between runs, this is easy to change, I was debating either to implement this or not. - Set to log Information level so logs informational things as well as errors by default. - Raising the level to Debug or more will log more granular information * Fixed an issue that prevented setting log levels * Update nvQuickSite/Controllers/DatabaseController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/DatabaseController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/FileSystemController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/UserSettings.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Program.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Main.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/VersionController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/PackageController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Controllers/IISController.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Update nvQuickSite/Start.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> Co-authored-by: David Poindexter <dpoindexter@nvisionative.com> * Refine User Settings UI and fix casing for Logs folder (#277) * Disable min, max, resize for dialogs and move User Settings, View Existing Sites, Delete Sites to Controls namespace (#281) * Allows deleting a site that is not started (#286) Closes #282 - Refactored some methods to not mix reusable logic with the UI focused classes. - Added more logging in the sites deletion code paths. - Reworked site and appPool stopping logic to avoid throwing exceptions on states that don't prevent the site deletion. * Move logging of user settings values to DBG instead of INF (#287) * Adds a link to the logs folder in the settings (#289) * Adds a link to the logs folder in the settings This allows users easy access to the logs * Renamed link for clarity * Fixes Typo and adjust logging (#290) - Fixes a typo in last step - Removes unused usings - Adjusts file deletion logging to not log too much in default level (get's called recursifvelly) * Add winget manifest for 1.4.2 (#291) * Improve visual and placement of View Logs feature and utilize Hand cursor where appropriate (#294) * Update version number to 2.0.0 (#295) Co-authored-by: Daniel Valadas <info@danielvaladas.com> Co-authored-by: Daniel Valadas <info@danielvaladas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #260
Now special files and folders (e.g.,
.gitfolders) are deleted properly.