Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Color Usage #265

Merged
merged 10 commits into from
Jun 24, 2021

Conversation

tksheppard
Copy link
Collaborator

Related to Issue

Fixes #

Description

  • Removed old SCSS variables for colors
  • Added a new color array
  • Setup to automatically turn any colors in the array to CSS variables (Hex)
  • Setup to automatically create an RGB set of variables of the colors in the array
  • Setup a function to reference CSS color variables
  • Created buttons mixins using new CSS variables
  • Created buttons using new mixins
  • Created backgrounds classes using new CSS variables
  • Created text-colors classes using new CSS variables
  • Created border-colors classes using new CSS variables
  • Replaced all color references with new color function

How Has This Been Tested?

  • Built and checked rendered outputs

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @tksheppard - see the one question related to the menu.

partials/_header.ascx Outdated Show resolved Hide resolved
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @tksheppard

@david-poindexter david-poindexter added the enhancement New feature or request label Jun 24, 2021
@david-poindexter david-poindexter added this to the 2.3.0 milestone Jun 24, 2021
@david-poindexter david-poindexter merged commit 052745f into nvisionative:develop Jun 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tksheppard tksheppard deleted the update_color-array branch June 24, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants