Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webp support #267

Merged

Conversation

tksheppard
Copy link
Collaborator

Related to Issue

Fixes #250

Description

  • Added imagemin-webp to optimize existing webp files
  • Added gulp-webp to convert other image types to webp
  • Updated imagemin to most recent version
  • Added variables calling plugins
  • Split Images task into 2 tasks
    • Optimize: Goes through and optimizes all images in src images folder, outputting into dist images
    • Convert: Converts all images to webp and places into dist images
  • Changes task images to be a series that runs Optimize and Convert tasks. This series outputs optimized images and a webp version or each image into the dist image folder. src images are untouched.

How Has This Been Tested?

I ran a full build process with several types of images (including webp) in the src folder and checked the output images. I cleared out the dist folder several times to make sure I was testing from a clean output.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo - thanks @tksheppard 🎉

@david-poindexter david-poindexter merged commit aff55b1 into nvisionative:develop Jun 28, 2021
@tksheppard tksheppard deleted the feature_webp-support branch June 28, 2021 20:14
@david-poindexter david-poindexter added this to the 2.3.0 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WebP support to build process
2 participants