-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update division signs #304
Update division signs #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tksheppard is there a reason you chose math.div()
instead of calc()
? From a readability perspective, I prefer calc()
and even though the latter is an expression, I think SCSS still tries to return a single number.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Wasn't aware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tksheppard - this looks great! 🎉
Related to Issue
Fixes #299
Description
This adds the scss math function which changes the use of division signs to instead use
math.div
. This will get rid of deprecation warnings.How Has This Been Tested?
Changed and compiled.
Screenshots (if appropriate):
Types of changes
Checklist: