Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update division signs #304

Merged

Conversation

tksheppard
Copy link
Collaborator

Related to Issue

Fixes #299

Description

This adds the scss math function which changes the use of division signs to instead use math.div. This will get rid of deprecation warnings.

How Has This Been Tested?

Changed and compiled.

Screenshots (if appropriate):

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tksheppard is there a reason you chose math.div() instead of calc()? From a readability perspective, I prefer calc() and even though the latter is an expression, I think SCSS still tries to return a single number.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tksheppard
Copy link
Collaborator Author

tksheppard commented Oct 10, 2022

Wasn't aware calc() allowed for that. Was going off the recommendation made in the console, which I stopped reading after math.div. I like calc() much more, and removes the usage of scss:math. So, I changed over to use calc().

@david-poindexter david-poindexter added the enhancement New feature or request label Oct 10, 2022
@david-poindexter david-poindexter added this to the 2.4.0 milestone Oct 10, 2022
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tksheppard - this looks great! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants