Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap 5 #311

Merged
merged 4 commits into from
Oct 23, 2022
Merged

Conversation

tksheppard
Copy link
Collaborator

@tksheppard tksheppard commented Oct 19, 2022

Related to Issue

Fixes #312

Description

This update increases the version of Bootstrap up to 5.2.2 which is a major version update. Luckily this didn't include many changes to the base theme itself, though people using nvQuickTheme will need to update their Bootstrap usage accordingly.

How Has This Been Tested?

Updated the Bootstrap dependency using yarn upgrade. Checked package.json and yarn.lock to make sure upgrade was clean. Updated all Bootstrap usage in theme. Removed deprecation suppression. Ran gulp build without any warnings or errors. Checked default theme in DNN to make sure no warnings or errors.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Note: I'm not sure if this will count as a breaking change. It doesn't break any nvQuickTheme functionality, but it may impact outside usage of the theme resources (modules, structured content, etc).

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @tksheppard - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Bootstrap to latest v5.x.x
2 participants