Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove divider borders from desktop submenu items #314

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Remove divider borders from desktop submenu items #314

merged 1 commit into from
Oct 31, 2022

Conversation

david-poindexter
Copy link
Member

Related to Issue

Fixes #313

Description

  • Clean up _nav.scss code formatting
  • Commented border styling just in case others would like to have the borders in their theme design.

How Has This Been Tested?

Local development environment.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added this to the 3.0.0 milestone Oct 31, 2022
@david-poindexter david-poindexter self-assigned this Oct 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@david-poindexter david-poindexter merged commit beadba6 into nvisionative:develop Oct 31, 2022
@david-poindexter david-poindexter deleted the issue-313 branch October 31, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@david-poindexter david-poindexter

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Remove divider borders from desktop submenus
1 participant
@david-poindexter