Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor desktop RazorMenu to remove duplicate code #329

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Refactor desktop RazorMenu to remove duplicate code #329

merged 1 commit into from
Nov 1, 2022

Conversation

david-poindexter
Copy link
Member

Related to Issue

Fixes #328

Description

  • Removes duplicate code in RazorMenu.cshtml for desktop.
  • Updates version of nvQuickTheme in preparation of the 3.0.0 release.
  • Removes rogue console.clear() from customMenu.js.

How Has This Been Tested?

Tested locally in DNN instance. Menu renders perfectly.

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added bug Something isn't working hacktoberfest labels Nov 1, 2022
@david-poindexter david-poindexter added this to the 3.0.0 milestone Nov 1, 2022
@david-poindexter david-poindexter self-assigned this Nov 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@david-poindexter david-poindexter merged commit 81b3f7c into nvisionative:develop Nov 1, 2022
@david-poindexter david-poindexter deleted the razormenu-refactor branch November 1, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@david-poindexter david-poindexter

Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Refactor desktop RazorMenu to remove duplicate code
1 participant
@david-poindexter