Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backlink to razor #331

Merged

Conversation

tksheppard
Copy link
Collaborator

Related to Issue

Fixes #330

Description

This PR removes the backlink creation from the JS and adds it into the DDR Menu Razor Template for the mobile menu. It also removes duplicate code by adding the description to all levels and makes description showing conditional on existence. Also updated the mr-1 reference for backlinks to appropriate me-1 for BS5.

How Has This Been Tested?

Tested in local environment, built, ran. With multiple pages across multiple levels, the mobile menu works as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @tksheppard 🎉

@david-poindexter david-poindexter added the bug Something isn't working label Nov 2, 2022
@david-poindexter david-poindexter added this to the 3.0.0 milestone Nov 2, 2022
@david-poindexter david-poindexter added the enhancement New feature or request label Nov 2, 2022
@david-poindexter david-poindexter merged commit dda68e2 into nvisionative:develop Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Back to ... in mobile menu
2 participants