[Fix] nvm install: Handle 'N/A' version instead of asking to install it

[PeterDaveHello]

Fixes #1304.

[PeterDaveHello]

hmmmm ... still trying to find out the problem here ... 😭

[PeterDaveHello]

I have no idea about the failed of Running "nvm exec --lts" should work, why nvm install --lts should make nvm use 1.0.0 work?

[ljharb]

I'm not sure I understand the problem. If you nvm use X, and X isn't installed, you get "You need to run "nvm install N/A" to install it before using it." - certainly the N/A should say nvm install X instead, but that's a pretty minor text change.

[PeterDaveHello]

It's very strange to ask for installing N/A I think, this change could make it smarter:

$ nvm use 4.2
N/A: version "4.2 -> v4.2.6" is not yet installed.

You need to run "nvm install 4.2" to install it before using it.

$ nvm use 4.20
Version '4.20' not found - try `nvm ls-remote` to browse available versions.

[ljharb]

I agree that a better error message is an improvement - but adding an nvm_remote_version call seems like overkill. I'd be fine with just using whatever they provided into nvm install in the error message.

[PeterDaveHello]

@ljharb do you mean just print nvm install $PROVIDED_VERSION ? I use nvm_remote_version because it can help to confirm if the $PROVIDED_VERSION is valid or not.

[ljharb]

I think that's nvm install's job :-)

[PeterDaveHello]

@ljharb what about this?

      if [ "${VERSION}" = 'N/A' ]; then
        nvm_err "N/A: version \"${PROVIDED_VERSION} -> ${VERSION}\" is not yet installed."
        nvm_err ""
        nvm_err "You need to run \"nvm install ${PROVIDED_VERSION}\" to install it before using it."
        return 3
      # This nvm_ensure_version_installed call can be a performance bottleneck
      # on shell startup. Perhaps we can optimize it away or make it faster.
      elif ! nvm_ensure_version_installed "${VERSION}"; then
        return $?
      fi

[ljharb]

That seems much more reasonable :-)

[manoharreddyporeddy]

Below commands worked:

• rm -fR ~/.nvm
• curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.32.0/install.sh | bash
• . ~/.nvm/nvm.sh
• nvm install 6.9.1
• node -e "console.log('Running Node.js ' + process.version)"