Improve awk usage for performance #1441
Conversation
| @@ -1109,7 +1109,7 @@ nvm_compute_checksum() { | |||
| command gsha256sum "${FILE}" | command awk '{print $1}' | |||
| elif nvm_has "openssl" && ! nvm_is_alias "openssl"; then | |||
| nvm_err 'Computing checksum with openssl dgst -sha256' | |||
| command openssl dgst -sha256 "${FILE}" | rev | command awk '{print $1}' | rev | |||
| command openssl dgst -sha256 "${FILE}" | command awk '{print $NF}' | |||
There was a problem hiding this comment.
I don't think these are the same - doesn't rev reverse the entire file, including the characters on every line? In my local testing this leads to different output.
There was a problem hiding this comment.
Don't we just get a single line by openssl dgst -sha256 in this case?
There was a problem hiding this comment.
echo abc | rev | awk '{print $1}' prints out cba - echo abc | awk '{print $NF}' prints out abc. These are not equivalent.
There was a problem hiding this comment.
but you rev it again, the comparison should be echo abc | rev | awk '{print $1}' | rev vs echo abc | awk '{print $NF}'
There was a problem hiding this comment.
lol, oops, i missed the second rev. Thanks for explaining.
| @@ -1209,7 +1209,7 @@ nvm_checksum() { | |||
| elif nvm_has "gsha256sum" && ! nvm_is_alias "gsha256sum"; then | |||
| NVM_CHECKSUM="$(command gsha256sum "${1-}" | command awk '{print $1}')" | |||
| elif nvm_has "openssl" && ! nvm_is_alias "openssl"; then | |||
| NVM_CHECKSUM="$(command openssl dgst -sha256 "${1-}" | rev | command awk '{print $1}' | rev)" | |||
| NVM_CHECKSUM="$(command openssl dgst -sha256 "${1-}" | command awk '{print $NF}')" | |||
|
@ljharb need a rebase or something? |
ljharb
force-pushed
the
performance-improvements
branch
from
87445d6
to
6cb12b0
Compare
ljharb
added
the
performance
|
nope, all set :-) |
No description provided.